Attention is currently required from: Paul Menzel, Jacob Garber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55075 )
Change subject: include: always unsigned long for size_t ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55075/comment/bb4a1285_b7113c27 PS1, Line 13: printf format specifiers) I'm not against cleaning this up in general, but note that printf() format strings should be using the `z` length specifier (e.g. "%zu") for size_t types anyway, which already works correctly.
https://review.coreboot.org/c/coreboot/+/55075/comment/bb09467d_9a162663 PS1, Line 15: This also removes a weird macro hack for defining ssize_t. Note that the same construct exists in libpayload, in case you want to fix that as well.
Patchset:
PS1:
Example build failure: […]
`z` is intended for use with size_t and needs to continue to work. I'm just not really sure why it doesn't here. I guess GCC hardcodes which type it expects as size_t for a given architecture? Which would be unfortunate, but if that's the case I think we need to keep this as it is because we still want to be able to use that modifier. (Still can clean up the macro stuff, at least.)
File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/55075/comment/56b93f57_ef4b0b2e PS1, Line 9: typedef signed long ssize_t; nit: might be nice to add a _Static_assert() check for the size (should be same as sizeof(void *)) like the stdint.h types have while you're here?
-
Julius Werner (Code Review)