[M] Change in coreboot[master]: mb/google/skyrim/var/winterhold: update thermal config - coreboot-gerrit

25 Oct 2022


      Attention is currently required from: Ian Feng, Jason Nien, EricKY Cheng, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68472 )
Change subject: mb/google/skyrim/var/winterhold: update thermal config
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68472/comment/0c89d14d_b0be5c38 
PS7, Line 6: 	register "system_configuration" = "4"
...
It is for 15W sku. […]
Thanks for the doc numbers.
Please add a comment with the doc number and that `4` indicates a 15W part.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0740cb5bb16cd53c2ee6937e32a974346012823
Gerrit-Change-Number: 68472
Gerrit-PatchSet: 7
Gerrit-Owner: EricKY Cheng ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-CC: Eric Peers epeers@google.com
Gerrit-CC: Karthikeyan Ramasubramanian kramasub@chromium.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-CC: Tim Van Patten timvp@google.com
Gerrit-Attention: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 22:53:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricKY Cheng ericky_cheng@compal.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Gerrit-MessageType: comment