Attention is currently required from: Tim Wawrzynczak, Paul Menzel. Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63792 )
Change subject: ec/google/chromeec: Add EC Mux device ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
OK. Just to clarify, if I add the devices to the override. […]
FWIW, when I *just* add the device to the brya0 override (no Kconfig enabled), and try to build coreboot within the Chrome OS chroot, I get the following error:
19:12:49 Jobs: 0 of 2 complete, 1 failed Load avg: 8.17, 6.09, 4.36
* Messages for package sys-boot/coreboot-9999 merged to /build/brya/: * Log file: /build/brya/tmp/portage/logs/sys-boot:coreboot-9999:20220502-191230.log * ERROR: sys-boot/coreboot-9999::chromiumos failed (compile phase): * emake failed * * Build log: /build/brya/tmp/portage/logs/sys-boot:coreboot-9999:20220502-191230.log * Stable log symlink: /build/brya/tmp/portage/sys-boot/coreboot-9999/temp/build.log * CWD: /build/brya/tmp/portage/sys-boot/coreboot-9999/work/coreboot-9999 * S: /build/brya/tmp/portage/sys-boot/coreboot-9999/work/coreboot-9999 * * A cros-workon package 'coreboot-9999' failed to build above. * Local branch for '/mnt/host/source/src/third_party/coreboot/3rdparty/libgfxinit' has no upstream and may be out of sync. * You may need to run: * git branch --set-upstream-to=m/main && git rebase --preserve-merges * * * A cros-workon package 'coreboot-9999' failed to build above. * Local branch for '/mnt/host/source/src/third_party/coreboot/3rdparty/libhwbase' has no upstream and may be out of sync. * You may need to run: * git branch --set-upstream-to=m/main && git rebase --preserve-merges
It compiles fine without that specific brya0 override change.
-
Prashant Malani (Code Review)