Attention is currently required from: Bao Zheng, Felix Held.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59581 )
Change subject: amdfwtool: remove duplicates
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59581/comment/488b1b5b_38bdc743
PS1, Line 12: TEST=build guybrush and confirm amdfw and coreboot.rom are identical
I don't think smu firmware makes any difference here since only duplicate entries are removed. (e.g. […]
Tested that aleena(stoneyridge chromebook device) boots without AMD_FW_PSP_TRUSTELETS and AMD_FW_PSP_SECURED_DEBUG binaries.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b86e24ba1c2769985e2864528e4dfcbf3cccc4b
Gerrit-Change-Number: 59581
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 02 Dec 2021 02:31:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment