Attention is currently required from: Furquan Shaikh, Rizwan Qureshi, Subrata Banik, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55965 )
Change subject: cpu/intel/common: Create get_cache_info() function
......................................................................
Patch Set 1:
(2 comments)
File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/55965/comment/b9d844fd_aaa1929c
PS1, Line 329: get_cache_info
@Tim, do you think we can move this code into x86 common ? and make same logic as https://review. […]
Yeah that sounds good, take the leaf and the ecx argument
https://review.coreboot.org/c/coreboot/+/55965/comment/50c818f5_596ef2c9
PS1, Line 331: 0x03
if we are taking cache_level as argument then do we still need macro ?
For this case, it would still be useful,
`#define INTEL_CACHE_PARAMETERS_CPUID_LAST_LEVEL_CACHE 0x03`
or similar
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095
Gerrit-Change-Number: 55965
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 01 Jul 2021 16:42:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment