Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42628 )
Change subject: sb/intel/lynxpoint/me_9.x.c: Drop dead code ......................................................................
sb/intel/lynxpoint/me_9.x.c: Drop dead code
Those functions are not being build-tested. Drop them.
Change-Id: I285c82712389ef7857001d339e4f8e37537d4199 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/lynxpoint/me_9.x.c 1 file changed, 0 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42628/1
diff --git a/src/southbridge/intel/lynxpoint/me_9.x.c b/src/southbridge/intel/lynxpoint/me_9.x.c index cdae271..77b3573 100644 --- a/src/southbridge/intel/lynxpoint/me_9.x.c +++ b/src/southbridge/intel/lynxpoint/me_9.x.c @@ -515,32 +515,6 @@ print_cap("Wireless LAN (WLAN)", cap->wlan); }
-#if CONFIG(CHROMEOS) && 0 /* DISABLED */ -/* Tell ME to issue a global reset */ -static int mkhi_global_reset(void) -{ - struct me_global_reset reset = { - .request_origin = GLOBAL_RESET_BIOS_POST, - .reset_type = CBM_RR_GLOBAL_RESET, - }; - struct mkhi_header mkhi = { - .group_id = MKHI_GROUP_ID_CBM, - .command = MKHI_GLOBAL_RESET, - }; - - /* Send request and wait for response */ - printk(BIOS_NOTICE, "ME: %s\n", __func__); - if (mei_sendrecv_mkhi(&mkhi, &reset, sizeof(reset), NULL, 0) < 0) { - /* No response means reset will happen shortly... */ - halt(); - } - - /* If the ME responded it rejected the reset request */ - printk(BIOS_ERR, "ME: Global Reset failed\n"); - return -1; -} -#endif - /* Send END OF POST message to the ME */ static int __unused mkhi_end_of_post(void) { @@ -892,22 +866,6 @@ (me.buffer_depth - 1); }
-#if 0 -/* This function is not yet being used, keep it in for the future. */ -static u32 host_to_me_words_room(void) -{ - struct mei_csr csr; - - read_me_csr(&csr); - if (!csr.ready) - return 0; - - read_host_csr(&csr); - return (csr.buffer_read_ptr - csr.buffer_write_ptr - 1) & - (csr.buffer_depth - 1); -} -#endif - struct mbp_payload { mbp_header header; u32 data[0];
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42628 )
Change subject: sb/intel/lynxpoint/me_9.x.c: Drop dead code ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42628 )
Change subject: sb/intel/lynxpoint/me_9.x.c: Drop dead code ......................................................................
Abandoned
empty commit, CB:43229 got merged in first