Change in coreboot[master]: mb/prodrive/hermes: Wrap UART driver by PCI device - coreboot-gerrit

6 Dec 2020


      Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48293 )
Change subject: mb/prodrive/hermes: Wrap UART driver by PCI device
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48293/4/src/mainboard/prodrive/herm... 
File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48293/4/src/mainboard/prodrive/herm... 
PS4, Line 177: 				device pci 19.2 on end
...
...
Maybe the driver needs to be edited to make that work
and as it's not the 19.2 pci device the driver will not work.
...
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48293
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I298247276ec95b2f599f1fcd399550a51b63aff1
Gerrit-Change-Number: 48293
Gerrit-PatchSet: 4
Gerrit-Owner:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 06 Dec 2020 09:25:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment