Attention is currently required from: Felix Held, Fred Reitberger, Martin L Roth.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80770?usp=email )
Change subject: mb/amd/birman_plus: Add glinda SOC option for Birman+ ......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/amd/birman_plus/Kconfig:
https://review.coreboot.org/c/coreboot/+/80770/comment/33856331_6f8d6a15 : PS3, Line 82: # This is a Birmanplus_Phoenix-specific override of soc/amd/(phoenix | glinda)/Kconfig
`Birmanplus_Phoenix` or just `birmanplus`?
Done
File src/mainboard/amd/birman_plus/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/80770/comment/daa4b756_f78f2f43 : PS3, Line 7: bool "-> Birmanplus for Glinda SoC"
Inconsistent capitalization - should this match the `BirmanPlus` for phoenix?
Done
File src/mainboard/amd/birman_plus/port_descriptors_phoenix.c:
https://review.coreboot.org/c/coreboot/+/80770/comment/3e98938b_d49a4797 : PS3, Line 7: //#include <soc/soc_util.h>
dead code
Done