Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34144 )
Change subject: src/soc/intel/common: set disable for Level/Edge Config ... ......................................................................
src/soc/intel/common: set disable for Level/Edge Config ...
... in PAD_CFG_NF_* and PAD_CFG_*_GPO macro from gpio_defs.h
Change-Id: Ideadc9cb39ae34079d160c1dd7a86f2851c5f76e Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 1 file changed, 12 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/34144/1
diff --git a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h index e1ddd4b..769016b 100644 --- a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h +++ b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h @@ -177,8 +177,8 @@
/* Native function configuration */ #define PAD_CFG_NF(pad, pull, rst, func) \ - _PAD_CFG_STRUCT(pad, PAD_RESET(rst) | PAD_FUNC(func), PAD_PULL(pull) | \ - PAD_IOSSTATE(TxLASTRxE)) + _PAD_CFG_STRUCT(pad, PAD_RESET(rst) | PAD_CFG0_TRIG_OFF | PAD_FUNC(func), \ + PAD_PULL(pull) | PAD_IOSSTATE(TxLASTRxE))
#if CONFIG(SOC_INTEL_COMMON_BLOCK_GPIO_PADCFG_PADTOL) /* Native 1.8V tolerant pad, only applies to some pads like I2C/I2S @@ -191,31 +191,33 @@
/* Native function configuration for standby state */ #define PAD_CFG_NF_IOSSTATE(pad, pull, rst, func, iosstate) \ - _PAD_CFG_STRUCT(pad, PAD_RESET(rst) | PAD_FUNC(func), PAD_PULL(pull) | \ - PAD_IOSSTATE(iosstate)) + _PAD_CFG_STRUCT(pad, PAD_RESET(rst) | PAD_CFG0_TRIG_OFF | PAD_FUNC(func), \ + PAD_PULL(pull) | PAD_IOSSTATE(iosstate))
/* Native function configuration for standby state, also configuring iostandby as masked */ #define PAD_CFG_NF_IOSTANDBY_IGNORE(pad, pull, rst, func) \ - _PAD_CFG_STRUCT(pad, PAD_RESET(rst) | PAD_FUNC(func), PAD_PULL(pull) | \ - PAD_IOSSTATE(IGNORE)) + _PAD_CFG_STRUCT(pad, PAD_RESET(rst) | PAD_CFG0_TRIG_OFF | PAD_FUNC(func), \ + PAD_PULL(pull) | PAD_IOSSTATE(IGNORE))
/* Native function configuration for standby state, also configuring iosstate and iosterm */ #define PAD_CFG_NF_IOSSTATE_IOSTERM(pad, pull, rst, func, iosstate, iosterm) \ - _PAD_CFG_STRUCT(pad, PAD_RESET(rst) | PAD_FUNC(func), PAD_PULL(pull) | \ - PAD_IOSSTATE(iosstate) | PAD_IOSTERM(iosterm)) + _PAD_CFG_STRUCT(pad, PAD_RESET(rst) | PAD_CFG0_TRIG_OFF | PAD_FUNC(func), \ + PAD_PULL(pull) | PAD_IOSSTATE(iosstate) | PAD_IOSTERM(iosterm))
/* General purpose output, no pullup/down. */ #define PAD_CFG_GPO(pad, val, rst) \ _PAD_CFG_STRUCT(pad, \ - PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_RX_DISABLE | !!val, \ + PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TRIG_OFF | \ + PAD_CFG0_RX_DISABLE | !!val, \ PAD_PULL(NONE) | PAD_IOSSTATE(TxLASTRxE))
/* General purpose output, with termination specified */ #define PAD_CFG_TERM_GPO(pad, val, pull, rst) \ _PAD_CFG_STRUCT(pad, \ - PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_RX_DISABLE | !!val, \ + PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TRIG_OFF | \ + PAD_CFG0_RX_DISABLE | !!val, \ PAD_PULL(pull) | PAD_IOSSTATE(TxLASTRxE))
/* General purpose output, no pullup/down. */
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34144 )
Change subject: src/soc/intel/common: set disable for Level/Edge Config ... ......................................................................
Patch Set 1:
This change is ready for review.
Maxim Polyakov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34144 )
Change subject: src/soc/intel/common: set disable for Level/Edge Config ... ......................................................................
Abandoned
Maxim Polyakov has restored this change. ( https://review.coreboot.org/c/coreboot/+/34144 )
Change subject: src/soc/intel/common: set disable for Level/Edge Config ... ......................................................................
Restored
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34144 )
Change subject: src/soc/intel/common: set disable for Level/Edge Config ... ......................................................................
Patch Set 2:
This change is ready for review.
Maxim Polyakov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34144 )
Change subject: src/soc/intel/common: set disable for Level/Edge Config ... ......................................................................
Abandoned
Maxim Polyakov has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/34144 )
Change subject: src/soc/intel/common: set disable for Level/Edge Config ... ......................................................................
Removed reviewer Patrick Rudolph.
-
Maxim Polyakov (Code Review)