Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42823 )
Change subject: arch/x86: Add memmove.c to x86 bootblock ......................................................................
arch/x86: Add memmove.c to x86 bootblock
This was specifically needed for vboot with psp_verstage, but adding it to always be built into bootblock if needed like memcpy & memset makes sense.
TEST=Build & boot trembyle BUG=None
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Ib724aaf1492edf053a593b42107684b7bf896592 --- M src/arch/x86/Makefile.inc M src/soc/amd/picasso/Makefile.inc 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/42823/1
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 6297384..10f86ca 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -94,6 +94,7 @@ bootblock-$(CONFIG_IDT_IN_EVERY_STAGE) += idt.S bootblock-y += memcpy.c bootblock-y += memset.c +bootblock-y += memmove.c bootblock-$(CONFIG_COLLECT_TIMESTAMPS_TSC) += timestamp.c bootblock-$(CONFIG_X86_TOP4G_BOOTMEDIA_MAP) += mmap_boot.c bootblock-$(CONFIG_BOOTBLOCK_NORMAL) += bootblock_normal.c diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index b18ad87..2f2d02d 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -23,7 +23,6 @@ bootblock-y += gpio.c bootblock-y += smi_util.c bootblock-y += config.c -bootblock-y += ../../../arch/x86/memmove.c
romstage-y += i2c.c romstage-y += i2c-x86.c
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42823 )
Change subject: arch/x86: Add memmove.c to x86 bootblock ......................................................................
Patch Set 1: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42823 )
Change subject: arch/x86: Add memmove.c to x86 bootblock ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42823 )
Change subject: arch/x86: Add memmove.c to x86 bootblock ......................................................................
arch/x86: Add memmove.c to x86 bootblock
This was specifically needed for vboot with psp_verstage, but adding it to always be built into bootblock if needed like memcpy & memset makes sense.
TEST=Build & boot trembyle BUG=None
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Ib724aaf1492edf053a593b42107684b7bf896592 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42823 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/arch/x86/Makefile.inc M src/soc/amd/picasso/Makefile.inc 2 files changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 2adb294..fa647b7 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -94,6 +94,7 @@ bootblock-$(CONFIG_IDT_IN_EVERY_STAGE) += idt.S bootblock-y += memcpy.c bootblock-y += memset.c +bootblock-y += memmove.c bootblock-$(CONFIG_COLLECT_TIMESTAMPS_TSC) += timestamp.c bootblock-$(CONFIG_X86_TOP4G_BOOTMEDIA_MAP) += mmap_boot.c bootblock-$(CONFIG_BOOTBLOCK_NORMAL) += bootblock_normal.c diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index e592f4a..5686782 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -22,7 +22,6 @@ bootblock-y += gpio.c bootblock-y += smi_util.c bootblock-y += config.c -bootblock-y += ../../../arch/x86/memmove.c
romstage-y += i2c.c romstage-y += romstage.c
-
Aaron Durbin (Code Review) -
Martin Roth (Code Review)
-
Raul Rangel (Code Review)