Change in coreboot[master]: mb/system76/lemp9: disable DSX

List overview All Threads
Download

newer

older

Change in coreboot[master]: mb:...

Change in coreboot[master]: mb/*:...

Jeremy Soller (Code Review)

20 Jul 2020 20 Jul '20

11:32 p.m.

Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: disable DSX ......................................................................

mb/system76/lemp9: disable DSX

The GPIOs required for DSX are not hooked up on the lemp9.

Tested on lemp9, suspend works correctly

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43629/1

diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 2d5b38f..9dc09e4 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -181,9 +181,9 @@ # Enable deep Sx states register "deep_s3_enable_ac" = "0" register "deep_s3_enable_dc" = "0" - register "deep_s5_enable_ac" = "1" - register "deep_s5_enable_dc" = "1" - register "deep_sx_config" = "DSX_EN_WAKE_PIN" + register "deep_s5_enable_ac" = "0" + register "deep_s5_enable_dc" = "0" + register "deep_sx_config" = "0"

# PM Util (soc/intel/cannonlake/pmutil.c) # GPE configuration

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Jeremy Soller (Code Review)

21 Jul 21 Jul

12:02 a.m.

Jeremy Soller has uploaded a new patch set (#7). ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: disable DSX ......................................................................

mb/system76/lemp9: disable DSX

The GPIOs required for DSX are not hooked up on the lemp9.

Tested on lemp9, suspend works correctly

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43629/7

Angel Pons (Code Review)

12:03 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: disable DSX ......................................................................

Patch Set 6:

(3 comments)

https://review.coreboot.org/c/coreboot/+/43629/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43629/6//COMMIT_MSG@11 PS6, Line 11: Tested on lemp9, suspend works correctly Please add a period at the end of the sentence.

https://review.coreboot.org/c/coreboot/+/43629/6/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43629/6/src/mainboard/system76/lemp... PS6, Line 181: Enable Not anymore!

https://review.coreboot.org/c/coreboot/+/43629/6/src/mainboard/system76/lemp... PS6, Line 182: register "deep_s3_enable_ac" = "0" : register "deep_s3_enable_dc" = "0" : register "deep_s5_enable_ac" = "0" : register "deep_s5_enable_dc" = "0" You can drop these four settings

Jeremy Soller (Code Review)

12:11 a.m.

Jeremy Soller has uploaded a new patch set (#8). ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: disable DSX ......................................................................

mb/system76/lemp9: disable DSX

The GPIOs required for DSX are not hooked up on the lemp9.

Tested on lemp9, suspend works correctly.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43629/8

Angel Pons (Code Review)

12:19 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: disable DSX ......................................................................

Patch Set 8: Code-Review+1

Michael Niewöhner (Code Review)

1:15 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: disable DSX ......................................................................

Patch Set 9: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 Jul 2020 23:15:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

8:02 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: disable DSX ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43629/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43629/11//COMMIT_MSG@9 PS11, Line 9: The GPIOs required for DSX are not hooked up on the lemp9. Please mention:

...

SLP_SUS# and a few others

as Michael did.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 11 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 06:02:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

4:20 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43629

to look at the new patch set (#12).

Change subject: mb/system76/lemp9: disable DSX ......................................................................

mb/system76/lemp9: disable DSX

SLP_SUS# required for DSX is not hooked up on the lemp9.

Tested on lemp9, suspend works correctly.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43629/12

Jeremy Soller (Code Review)

22 Jul 22 Jul

2:45 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43629

to look at the new patch set (#16).

Change subject: mb/system76/lemp9: disable DSX ......................................................................

mb/system76/lemp9: disable DSX

SLP_SUS# required for DSX is not hooked up on the lemp9.

Tested on lemp9, suspend works correctly.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43629/16

Jeremy Soller (Code Review)

4:09 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43629

to look at the new patch set (#18).

Change subject: mb/system76/lemp9: disable DSX ......................................................................

mb/system76/lemp9: disable DSX

SLP_SUS# required for DSX is not hooked up on the lemp9.

Tested on lemp9, suspend works correctly.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43629/18

Michael Niewöhner (Code Review)

30 Aug 30 Aug

3:18 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: disable DSX ......................................................................

Patch Set 19:

tested; suspend works fine

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 30 Aug 2020 13:18:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

6 Sep 6 Sep

2:04 a.m.

Felix Singer has uploaded a new patch set (#20) to the change originally created by Jeremy Soller. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: disable DSX ......................................................................

mb/system76/lemp9: disable DSX

The GPIOs required for DSX are not hooked up on the lemp9.

Tested on lemp9, suspend works correctly.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43629/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

2:15 a.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Drop DSX settings

Felix Singer has uploaded a new patch set (#21) to the change originally created by Jeremy Soller. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: Drop DSX settings ......................................................................

mb/system76/lemp9: Drop DSX settings

The GPIOs required for DSX are not hooked up on the lemp9. Therefore, drop the DSX settings.

Tested on lemp9, suspend works correctly.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43629/21

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

2:16 a.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Drop DSX settings

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: Drop DSX settings ......................................................................

Patch Set 21: Code-Review+2

(4 comments)

https://review.coreboot.org/c/coreboot/+/43629/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43629/6//COMMIT_MSG@11 PS6, Line 11: Tested on lemp9, suspend works correctly

...

Please add a period at the end of the sentence.

Done

https://review.coreboot.org/c/coreboot/+/43629/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43629/11//COMMIT_MSG@9 PS11, Line 9: The GPIOs required for DSX are not hooked up on the lemp9.

...

Please mention: […]

Done

https://review.coreboot.org/c/coreboot/+/43629/6/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43629/6/src/mainboard/system76/lemp... PS6, Line 181: Enable

...

Not anymore!

Done

...

You can drop these four settings

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 06 Sep 2020 00:16:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

4:35 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Drop DeepSx settings

Michael Niewöhner has uploaded a new patch set (#22) to the change originally created by Jeremy Soller. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: Drop DeepSx settings ......................................................................

mb/system76/lemp9: Drop DeepSx settings

The GPIOs required for DeepSx (e.g. SLP_SUS#) are not hooked up on the lemp9. Therefore, drop the DeepSx settings.

Tested on lemp9, suspend works correctly.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43629/22

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 22 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

4:41 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Drop DeepSx settings

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: Drop DeepSx settings ......................................................................

Patch Set 22: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 22 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 06 Sep 2020 14:41:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

4:41 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Drop DeepSx settings

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: Drop DeepSx settings ......................................................................

mb/system76/lemp9: Drop DeepSx settings

The GPIOs required for DeepSx (e.g. SLP_SUS#) are not hooked up on the lemp9. Therefore, drop the DeepSx settings.

Tested on lemp9, suspend works correctly.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Reviewed-on: https://review.coreboot.org/c/coreboot/+/43629 Reviewed-by: Michael Niewöhner Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 8 deletions(-)

Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Michael Niewöhner: Looks good to me, approved

diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index da96dd3..e0da72a 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -153,14 +153,6 @@ # Address 0x90: Decode 0xF00 - 0xFFF (AP/EC debug) register "gen4_dec" = "0x00fc0F01"

-# PMC (soc/intel/cannonlake/pmc.c) - # Enable deep Sx states - register "deep_s3_enable_ac" = "0" - register "deep_s3_enable_dc" = "0" - register "deep_s5_enable_ac" = "1" - register "deep_s5_enable_dc" = "1" - register "deep_sx_config" = "DSX_EN_WAKE_PIN" - # PM Util (soc/intel/cannonlake/pmutil.c) # GPE configuration # Note that GPE events called out in ASL code rely on this

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 23 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

5:50 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Drop DeepSx settings

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43629 )

Change subject: mb/system76/lemp9: Drop DeepSx settings ......................................................................

Patch Set 23:

Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17879 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17878 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17877 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17876 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17875 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/17882 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17881 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17880

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/43629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab179abd7adc3a65dcfc43ce1b5742d514b711fb Gerrit-Change-Number: 43629 Gerrit-PatchSet: 23 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 06 Sep 2020 15:50:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1539

days inactive

1587

days old

coreboot-gerrit@coreboot.org

17 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Angel Pons (Code Review)
Felix Singer (Code Review)
Jeremy Soller (Code Review)
Michael Niewöhner (Code Review)
Paul Menzel (Code Review)