Change in ...coreboot[master]: mb/google/hatch: Add overridetree to hatch variant

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Shelley Chen (Code Review)

20 Mar 2019 20 Mar '19

9:04 p.m.

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32003

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

mb/google/hatch: Add overridetree to hatch variant

Mimic the serialio settings from cml_u variant of coffeelake rvp

BUG=b:128347800 BRANCH=None TEST=abuild

Change-Id: I6a9ec778d74cd48a2e1c79f8e669a9a6a6a9477d Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/Kconfig A src/mainboard/google/hatch/variants/hatch/overridetree.cb 2 files changed, 22 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/32003/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 629b125..d88c795 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -38,6 +38,10 @@ string default "variants/baseboard/devicetree.cb"

+config OVERRIDE_DEVICETREE + string + default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb" if !BOARD_GOOGLE_HATCH_WHL + config DIMM_MAX int default 2 diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb new file mode 100644 index 0000000..62da635 --- /dev/null +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -0,0 +1,18 @@ +chip soc/intel/cannonlake + + register "SerialIoDevMode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C3] = PchSerialIoPci, + [PchSerialIoIndexI2C4] = PchSerialIoDisabled, + [PchSerialIoIndexI2C5] = PchSerialIoPci, + [PchSerialIoIndexSPI0] = PchSerialIoPci, + [PchSerialIoIndexSPI1] = PchSerialIoPci, + [PchSerialIoIndexSPI2] = PchSerialIoDisabled, + [PchSerialIoIndexUART0] = PchSerialIoSkipInit, + [PchSerialIoIndexUART1] = PchSerialIoDisabled, + [PchSerialIoIndexUART2] = PchSerialIoSkipInit, + }" + +end \ No newline at end of file

Attachments:

attachment.htm (text/html — 4.6 KB)

Show replies by date

Furquan Shaikh (Code Review)

20 Mar 20 Mar

9:16 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32003 )

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/Kconfig@4... PS1, Line 41: OVERRIDE_DEVICETREE nit: Place this in alphabetical order?

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... PS1, Line 18: end nit: need a newline at end of file

-- To view, visit https://review.coreboot.org/c/coreboot/+/32003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a9ec778d74cd48a2e1c79f8e669a9a6a6a9477d Gerrit-Change-Number: 32003 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Wed, 20 Mar 2019 21:16:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shelley Chen (Code Review)

9:18 p.m.

Hello Evan Green, Tim Wawrzynczak, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32003

to look at the new patch set (#2).

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

mb/google/hatch: Add overridetree to hatch variant

Mimic the serialio settings from cml_u variant of coffeelake rvp

BUG=b:128347800 BRANCH=None TEST=abuild

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/32003/2

Furquan Shaikh (Code Review)

9:25 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32003 )

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/Kconfig@4... PS1, Line 43: BOARD_GOOGLE_HATCH_WHL Now that we are adding override tree, we should move devices like touchscreen, trackpad, etc. to override tree. Okay to do in follow-up change

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... PS1, Line 8: PchSerialIoDisabled Why? We are using this: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... PS1, Line 13: PchSerialIoSkipInit PchSerialIoPci should probably be okay here?

https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... PS1, Line 15: PchSerialIoSkipInit Why? Shouldn't this be PchSerialIoDisabled?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a9ec778d74cd48a2e1c79f8e669a9a6a6a9477d Gerrit-Change-Number: 32003 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Wed, 20 Mar 2019 21:25:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shelley Chen (Code Review)

9:33 p.m.

Hello Evan Green, Tim Wawrzynczak, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32003

to look at the new patch set (#3).

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

mb/google/hatch: Add overridetree to hatch variant

Add serialio settings to hatch. Only applies to CML.

BUG=b:128347800 BRANCH=None TEST=abuild

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/32003/3

Shelley Chen (Code Review)

9:36 p.m.

Hello Evan Green, Tim Wawrzynczak, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32003

to look at the new patch set (#4).

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

mb/google/hatch: Add overridetree to hatch variant

Add serialio settings to hatch. Only applies to CML.

BUG=b:128347800 BRANCH=None TEST=abuild

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/32003/4

Furquan Shaikh (Code Review)

9:37 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32003 )

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a9ec778d74cd48a2e1c79f8e669a9a6a6a9477d Gerrit-Change-Number: 32003 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 20 Mar 2019 21:37:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

22 Mar 22 Mar

12:23 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32003 )

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

mb/google/hatch: Add overridetree to hatch variant

Add serialio settings to hatch. Only applies to CML.

BUG=b:128347800 BRANCH=None TEST=abuild

Change-Id: I6a9ec778d74cd48a2e1c79f8e669a9a6a6a9477d Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32003 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/Kconfig A src/mainboard/google/hatch/variants/hatch/overridetree.cb 2 files changed, 22 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index f632a02..19c7184 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -80,6 +80,10 @@ int default 8

+config OVERRIDE_DEVICETREE + string + default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb" if !BOARD_GOOGLE_HATCH_WHL + config TPM_TIS_ACPI_INTERRUPT int default 53 # GPE0_DW1_21 (GPP_C21) diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb new file mode 100644 index 0000000..6e6414e --- /dev/null +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -0,0 +1,18 @@ +chip soc/intel/cannonlake + + register "SerialIoDevMode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C3] = PchSerialIoPci, + [PchSerialIoIndexI2C4] = PchSerialIoPci, + [PchSerialIoIndexI2C5] = PchSerialIoPci, + [PchSerialIoIndexSPI0] = PchSerialIoPci, + [PchSerialIoIndexSPI1] = PchSerialIoPci, + [PchSerialIoIndexSPI2] = PchSerialIoDisabled, + [PchSerialIoIndexUART0] = PchSerialIoPci, + [PchSerialIoIndexUART1] = PchSerialIoDisabled, + [PchSerialIoIndexUART2] = PchSerialIoDisabled, + }" + +end

-- To view, visit https://review.coreboot.org/c/coreboot/+/32003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a9ec778d74cd48a2e1c79f8e669a9a6a6a9477d Gerrit-Change-Number: 32003 Gerrit-PatchSet: 6 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Subrata Banik (Code Review)

11 Apr 11 Apr

6:09 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32003 )

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32003/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:

https://review.coreboot.org/#/c/32003/6/src/mainboard/google/hatch/variants/... PS6, Line 13: PchSerialIoPci should be PchSerialIoSkipInit to skip fsp to initial uart....

-- To view, visit https://review.coreboot.org/c/coreboot/+/32003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a9ec778d74cd48a2e1c79f8e669a9a6a6a9477d Gerrit-Change-Number: 32003 Gerrit-PatchSet: 6 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subrata.banik@intel.com Gerrit-Comment-Date: Thu, 11 Apr 2019 06:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

6:11 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32003 )

Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32003/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:

https://review.coreboot.org/#/c/32003/6/src/mainboard/google/hatch/variants/... PS6, Line 13: PchSerialIoPci

...

should be PchSerialIoSkipInit to skip fsp to initial uart....

https://review.coreboot.org/c/coreboot/+/32278/1/src/mainboard/google/hatch/...

-- To view, visit https://review.coreboot.org/c/coreboot/+/32003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a9ec778d74cd48a2e1c79f8e669a9a6a6a9477d Gerrit-Change-Number: 32003 Gerrit-PatchSet: 6 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Subrata Banik subrata.banik@intel.com Gerrit-Comment-Date: Thu, 11 Apr 2019 06:11:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Gerrit-MessageType: comment

2053

days inactive

2075

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Shelley Chen (Code Review)
Subrata Banik (Code Review)