Change in coreboot[master]: amd/cezanne: adding support for the changed AMD FSP API for USB PHY
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Julian Schroeder has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54065 )
Change subject: amd/cezanne: adding support for the changed AMD FSP API for USB PHY ......................................................................
Patch Set 2:
(3 comments)
File src/vendorcode/amd/fsp/cezanne/FspUsb.h:
https://review.coreboot.org/c/coreboot/+/54065/comment/68be28d2_b23d7c05 PS1, Line 10: #if 0
?
oops! I have to take this out.
https://review.coreboot.org/c/coreboot/+/54065/comment/bcb6de39_a99f2665 PS1, Line 44: compdstune
Is there documentation that could be added to these? Or maybe we can define some enums?
This stuff is explained in the USB2 spec and the PPR. I don't think we can explain this properly in a comment.
https://review.coreboot.org/c/coreboot/+/54065/comment/748307d1_4cc825c7 PS1, Line 67:
nit: indenting
will update the patch in a minute
-
Julian Schroeder (Code Review)