Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20741 )
Change subject: mb/google/soraka: Camera PMIC runtime power control ......................................................................
Patch Set 8:
(1 comment)
Is
https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/soraka/gpio.c:
https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/variants/... PS8, Line 146: PAD_CFG_GPO(GPP_C11, 0, DEEP),
this change should be done for poppy/gpio.c as well.
Is there any update on this. We are currently waiting on this change to verify the behavior of camera on boot-up and confirm power consumption in suspend states. For now we can skip the about suggestion of separate gpio table. But we at least need following two things: 1. This gpio change needs to be done for poppy as well 2. Did you confirm the tests that Rajmohan mentioned along with the changes in this CL?
-
Furquan Shaikh (Code Review)