Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/29967/14/src/soc/qualcomm/qcs405/qclib_execu...
File src/soc/qualcomm/qcs405/qclib_execute.c:
https://review.coreboot.org/#/c/29967/14/src/soc/qualcomm/qcs405/qclib_execu...
PS14, Line 27: PMIC_NAME "/
In the rpm loader you're directly using the strings in the PROG_INIT() macro. For consistency, please pick one way to handle it for qcs405. I'd have a slight preference for using strings directly (like rpm loader)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Gerrit-Change-Number: 29967
Gerrit-PatchSet: 14
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 06 Mar 2019 11:32:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment