Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 36:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/a01aa718_eb7cf8f6 PS36, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/a1717992_e307da7f PS36, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/5cbc4608_2ab92446 PS36, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/31b6c717_541e0092 PS36, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/46df2a3b_6da988a6 PS36, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/0c03fa5b_d956d3d7 PS36, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/a8310e27_1e9c06ad PS36, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/fa503351_c0e20cc3 PS36, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/51521fa2_62286a43 PS36, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/22f0782c_e4fc8fa9 PS36, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/5481beb7_3c6075b9 PS36, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/259e9660_daf34c13 PS36, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/d84b5bbf_3a9893a4 PS36, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/82b8e930_2c2c5f97 PS36, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/ebe66924_093b8f00 PS36, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/f8c7c3fe_23652a08 PS36, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/38385ac2_5dc8985b PS36, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/58dd385d_0e174a16 PS36, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/c0243526_e1a50d09 PS36, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/1f742c03_f46439aa PS36, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/6a29d3b6_2653f4f5 PS36, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/1bb66459_47b1a0a8 PS36, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/40316707_d046165a PS36, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/a4c6216b_e2947026 PS36, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/865af775_1b610319 PS36, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119422): https://review.coreboot.org/c/coreboot/+/49767/comment/c4d1bf17_739c1758 PS36, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)