HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44093 )
Change subject: src: Remove unused 'include <delay.h>' ......................................................................
src: Remove unused 'include <delay.h>'
Change-Id: I6afea5c102299e570378a1656d3dcd329a373399 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/crb/tpm.c M src/mainboard/getac/p470/early_init.c M src/mainboard/google/hatch/variants/nightfury/ramstage.c M src/mainboard/lenovo/t440p/smihandler.c M src/mainboard/supermicro/x11-lga1151-series/bootblock.c M src/northbridge/intel/ironlake/northbridge.c M src/soc/amd/picasso/psp_verstage/fch.c M src/soc/amd/picasso/southbridge.c M src/soc/intel/common/block/imc/imc.c M src/soc/mediatek/mt8173/i2c.c M src/soc/mediatek/mt8183/spm.c M src/soc/qualcomm/sc7180/gpio.c M src/soc/qualcomm/sc7180/qupv3_spi.c M src/soc/qualcomm/sc7180/usb.c M src/superio/aspeed/common/early_config.c 15 files changed, 0 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/44093/1
diff --git a/src/drivers/crb/tpm.c b/src/drivers/crb/tpm.c index 6436725..575f973 100644 --- a/src/drivers/crb/tpm.c +++ b/src/drivers/crb/tpm.c @@ -14,7 +14,6 @@
#include <timer.h> #include <console/console.h> -#include <delay.h> #include <device/mmio.h> #include <string.h> #include <soc/pci_devs.h> diff --git a/src/mainboard/getac/p470/early_init.c b/src/mainboard/getac/p470/early_init.c index 8550f69..087e279 100644 --- a/src/mainboard/getac/p470/early_init.c +++ b/src/mainboard/getac/p470/early_init.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <stdint.h> #include <arch/io.h> -#include <delay.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> #include <option.h> diff --git a/src/mainboard/google/hatch/variants/nightfury/ramstage.c b/src/mainboard/google/hatch/variants/nightfury/ramstage.c index d5a57af..0e6eae6 100644 --- a/src/mainboard/google/hatch/variants/nightfury/ramstage.c +++ b/src/mainboard/google/hatch/variants/nightfury/ramstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <delay.h> #include <gpio.h> #include <baseboard/variants.h> #include <soc/gpio.h> diff --git a/src/mainboard/lenovo/t440p/smihandler.c b/src/mainboard/lenovo/t440p/smihandler.c index e3da85d..8cc5135 100644 --- a/src/mainboard/lenovo/t440p/smihandler.c +++ b/src/mainboard/lenovo/t440p/smihandler.c @@ -5,7 +5,6 @@ #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> #include <ec/lenovo/h8/h8.h> -#include <delay.h> #include <southbridge/intel/lynxpoint/pch.h>
#define GPE_EC_SCI 1 diff --git a/src/mainboard/supermicro/x11-lga1151-series/bootblock.c b/src/mainboard/supermicro/x11-lga1151-series/bootblock.c index 94eeee7..3e5751c 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/bootblock.c +++ b/src/mainboard/supermicro/x11-lga1151-series/bootblock.c @@ -5,7 +5,6 @@ #include <variant/gpio.h> #include <superio/aspeed/common/aspeed.h> #include <superio/aspeed/ast2400/ast2400.h> -#include <delay.h> #include <console/uart.h>
static void early_config_gpio(void) diff --git a/src/northbridge/intel/ironlake/northbridge.c b/src/northbridge/intel/ironlake/northbridge.c index c1a2840..d70460f 100644 --- a/src/northbridge/intel/ironlake/northbridge.c +++ b/src/northbridge/intel/ironlake/northbridge.c @@ -4,7 +4,6 @@ #include <acpi/acpi.h> #include <device/pci_ops.h> #include <stdint.h> -#include <delay.h> #include <cpu/intel/model_2065x/model_2065x.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/amd/picasso/psp_verstage/fch.c b/src/soc/amd/picasso/psp_verstage/fch.c index 5096088..499f4e2 100644 --- a/src/soc/amd/picasso/psp_verstage/fch.c +++ b/src/soc/amd/picasso/psp_verstage/fch.c @@ -11,7 +11,6 @@ #include <bl_uapp/bl_errorcodes_public.h> #include <bl_uapp/bl_syscall_public.h> #include <console/console.h> -#include <delay.h> #include <soc/i2c.h> #include <soc/southbridge.h> #include <stdint.h> diff --git a/src/soc/amd/picasso/southbridge.c b/src/soc/amd/picasso/southbridge.c index 4cd24dd..6305e8e 100644 --- a/src/soc/amd/picasso/southbridge.c +++ b/src/soc/amd/picasso/southbridge.c @@ -24,7 +24,6 @@ #include <soc/smi.h> #include <soc/uart.h> #include <soc/amd_pci_int_defs.h> -#include <delay.h> #include <soc/pci_devs.h> #include <soc/nvs.h> #include <types.h> diff --git a/src/soc/intel/common/block/imc/imc.c b/src/soc/intel/common/block/imc/imc.c index 8c49dcd..57c7fa8 100644 --- a/src/soc/intel/common/block/imc/imc.c +++ b/src/soc/intel/common/block/imc/imc.c @@ -6,7 +6,6 @@ */
#include <console/console.h> -#include <delay.h> #include <device/pci_ops.h> #include <intelblocks/imc.h> #include <soc/pci_devs.h> diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c index f80fb97..ff803c3 100644 --- a/src/soc/mediatek/mt8173/i2c.c +++ b/src/soc/mediatek/mt8173/i2c.c @@ -2,7 +2,6 @@
#include <assert.h> #include <console/console.h> -#include <delay.h> #include <device/i2c_simple.h> #include <device/mmio.h> #include <soc/addressmap.h> diff --git a/src/soc/mediatek/mt8183/spm.c b/src/soc/mediatek/mt8183/spm.c index 2aa10b4..01c6a2f 100644 --- a/src/soc/mediatek/mt8183/spm.c +++ b/src/soc/mediatek/mt8183/spm.c @@ -3,7 +3,6 @@ #include <assert.h> #include <cbfs.h> #include <console/console.h> -#include <delay.h> #include <device/mmio.h> #include <endian.h> #include <soc/emi.h> diff --git a/src/soc/qualcomm/sc7180/gpio.c b/src/soc/qualcomm/sc7180/gpio.c index 51d9135..f175ce5 100644 --- a/src/soc/qualcomm/sc7180/gpio.c +++ b/src/soc/qualcomm/sc7180/gpio.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> -#include <delay.h> #include <device/mmio.h> #include <timestamp.h> #include <types.h> diff --git a/src/soc/qualcomm/sc7180/qupv3_spi.c b/src/soc/qualcomm/sc7180/qupv3_spi.c index a145417..d086a27 100644 --- a/src/soc/qualcomm/sc7180/qupv3_spi.c +++ b/src/soc/qualcomm/sc7180/qupv3_spi.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> -#include <delay.h> #include <lib.h> #include <soc/clock.h> #include <soc/gpio.h> diff --git a/src/soc/qualcomm/sc7180/usb.c b/src/soc/qualcomm/sc7180/usb.c index c4b65d6..41032b7 100644 --- a/src/soc/qualcomm/sc7180/usb.c +++ b/src/soc/qualcomm/sc7180/usb.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <console/console.h> -#include <delay.h> #include <device/mmio.h> #include <soc/usb.h> #include <soc/clock.h> diff --git a/src/superio/aspeed/common/early_config.c b/src/superio/aspeed/common/early_config.c index fe780ff..b0aab89 100644 --- a/src/superio/aspeed/common/early_config.c +++ b/src/superio/aspeed/common/early_config.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <arch/io.h> -#include <delay.h> #include <device/pnp_def.h> #include <device/pnp_ops.h> #include <stdint.h>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44093 )
Change subject: src: Remove unused 'include <delay.h>' ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44093/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/nightfury/ramstage.c:
https://review.coreboot.org/c/coreboot/+/44093/1/src/mainboard/google/hatch/... PS1, Line 14: */ I wonder why nothing is done here.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44093 )
Change subject: src: Remove unused 'include <delay.h>' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44093/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/nightfury/ramstage.c:
https://review.coreboot.org/c/coreboot/+/44093/1/src/mainboard/google/hatch/... PS1, Line 14: */
I wonder why nothing is done here.
out of scope
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44093 )
Change subject: src: Remove unused 'include <delay.h>' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44093/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/nightfury/ramstage.c:
https://review.coreboot.org/c/coreboot/+/44093/1/src/mainboard/google/hatch/... PS1, Line 14: */
out of scope
I know, but it looks weird. I think I marked this as resolved (if I didn't, I slipped up. Sorry)
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44093 )
Change subject: src: Remove unused 'include <delay.h>' ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44093 )
Change subject: src: Remove unused 'include <delay.h>' ......................................................................
src: Remove unused 'include <delay.h>'
Change-Id: I6afea5c102299e570378a1656d3dcd329a373399 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44093 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/crb/tpm.c M src/mainboard/getac/p470/early_init.c M src/mainboard/google/hatch/variants/nightfury/ramstage.c M src/mainboard/lenovo/t440p/smihandler.c M src/mainboard/supermicro/x11-lga1151-series/bootblock.c M src/northbridge/intel/ironlake/northbridge.c M src/soc/amd/picasso/psp_verstage/fch.c M src/soc/amd/picasso/southbridge.c M src/soc/intel/common/block/imc/imc.c M src/soc/mediatek/mt8173/i2c.c M src/soc/mediatek/mt8183/spm.c M src/soc/qualcomm/sc7180/gpio.c M src/soc/qualcomm/sc7180/qupv3_spi.c M src/soc/qualcomm/sc7180/usb.c M src/superio/aspeed/common/early_config.c 15 files changed, 0 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/drivers/crb/tpm.c b/src/drivers/crb/tpm.c index 6436725..575f973 100644 --- a/src/drivers/crb/tpm.c +++ b/src/drivers/crb/tpm.c @@ -14,7 +14,6 @@
#include <timer.h> #include <console/console.h> -#include <delay.h> #include <device/mmio.h> #include <string.h> #include <soc/pci_devs.h> diff --git a/src/mainboard/getac/p470/early_init.c b/src/mainboard/getac/p470/early_init.c index 8550f69..087e279 100644 --- a/src/mainboard/getac/p470/early_init.c +++ b/src/mainboard/getac/p470/early_init.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <stdint.h> #include <arch/io.h> -#include <delay.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> #include <option.h> diff --git a/src/mainboard/google/hatch/variants/nightfury/ramstage.c b/src/mainboard/google/hatch/variants/nightfury/ramstage.c index d5a57af..0e6eae6 100644 --- a/src/mainboard/google/hatch/variants/nightfury/ramstage.c +++ b/src/mainboard/google/hatch/variants/nightfury/ramstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <delay.h> #include <gpio.h> #include <baseboard/variants.h> #include <soc/gpio.h> diff --git a/src/mainboard/lenovo/t440p/smihandler.c b/src/mainboard/lenovo/t440p/smihandler.c index e3da85d..8cc5135 100644 --- a/src/mainboard/lenovo/t440p/smihandler.c +++ b/src/mainboard/lenovo/t440p/smihandler.c @@ -5,7 +5,6 @@ #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> #include <ec/lenovo/h8/h8.h> -#include <delay.h> #include <southbridge/intel/lynxpoint/pch.h>
#define GPE_EC_SCI 1 diff --git a/src/mainboard/supermicro/x11-lga1151-series/bootblock.c b/src/mainboard/supermicro/x11-lga1151-series/bootblock.c index 94eeee7..3e5751c 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/bootblock.c +++ b/src/mainboard/supermicro/x11-lga1151-series/bootblock.c @@ -5,7 +5,6 @@ #include <variant/gpio.h> #include <superio/aspeed/common/aspeed.h> #include <superio/aspeed/ast2400/ast2400.h> -#include <delay.h> #include <console/uart.h>
static void early_config_gpio(void) diff --git a/src/northbridge/intel/ironlake/northbridge.c b/src/northbridge/intel/ironlake/northbridge.c index b99e2d5..1272f5a 100644 --- a/src/northbridge/intel/ironlake/northbridge.c +++ b/src/northbridge/intel/ironlake/northbridge.c @@ -4,7 +4,6 @@ #include <acpi/acpi.h> #include <device/pci_ops.h> #include <stdint.h> -#include <delay.h> #include <cpu/intel/model_2065x/model_2065x.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/amd/picasso/psp_verstage/fch.c b/src/soc/amd/picasso/psp_verstage/fch.c index 63caa2f..89e7014 100644 --- a/src/soc/amd/picasso/psp_verstage/fch.c +++ b/src/soc/amd/picasso/psp_verstage/fch.c @@ -11,7 +11,6 @@ #include <bl_uapp/bl_errorcodes_public.h> #include <bl_uapp/bl_syscall_public.h> #include <console/console.h> -#include <delay.h> #include <soc/i2c.h> #include <soc/southbridge.h> #include <stdint.h> diff --git a/src/soc/amd/picasso/southbridge.c b/src/soc/amd/picasso/southbridge.c index df2d0d0..61dc341 100644 --- a/src/soc/amd/picasso/southbridge.c +++ b/src/soc/amd/picasso/southbridge.c @@ -24,7 +24,6 @@ #include <soc/smi.h> #include <soc/uart.h> #include <soc/amd_pci_int_defs.h> -#include <delay.h> #include <soc/pci_devs.h> #include <soc/nvs.h> #include <types.h> diff --git a/src/soc/intel/common/block/imc/imc.c b/src/soc/intel/common/block/imc/imc.c index 8c49dcd..57c7fa8 100644 --- a/src/soc/intel/common/block/imc/imc.c +++ b/src/soc/intel/common/block/imc/imc.c @@ -6,7 +6,6 @@ */
#include <console/console.h> -#include <delay.h> #include <device/pci_ops.h> #include <intelblocks/imc.h> #include <soc/pci_devs.h> diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c index f80fb97..ff803c3 100644 --- a/src/soc/mediatek/mt8173/i2c.c +++ b/src/soc/mediatek/mt8173/i2c.c @@ -2,7 +2,6 @@
#include <assert.h> #include <console/console.h> -#include <delay.h> #include <device/i2c_simple.h> #include <device/mmio.h> #include <soc/addressmap.h> diff --git a/src/soc/mediatek/mt8183/spm.c b/src/soc/mediatek/mt8183/spm.c index 2aa10b4..01c6a2f 100644 --- a/src/soc/mediatek/mt8183/spm.c +++ b/src/soc/mediatek/mt8183/spm.c @@ -3,7 +3,6 @@ #include <assert.h> #include <cbfs.h> #include <console/console.h> -#include <delay.h> #include <device/mmio.h> #include <endian.h> #include <soc/emi.h> diff --git a/src/soc/qualcomm/sc7180/gpio.c b/src/soc/qualcomm/sc7180/gpio.c index a74a799..67204e8 100644 --- a/src/soc/qualcomm/sc7180/gpio.c +++ b/src/soc/qualcomm/sc7180/gpio.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> -#include <delay.h> #include <device/mmio.h> #include <types.h>
diff --git a/src/soc/qualcomm/sc7180/qupv3_spi.c b/src/soc/qualcomm/sc7180/qupv3_spi.c index a145417..d086a27 100644 --- a/src/soc/qualcomm/sc7180/qupv3_spi.c +++ b/src/soc/qualcomm/sc7180/qupv3_spi.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> -#include <delay.h> #include <lib.h> #include <soc/clock.h> #include <soc/gpio.h> diff --git a/src/soc/qualcomm/sc7180/usb.c b/src/soc/qualcomm/sc7180/usb.c index c4b65d6..41032b7 100644 --- a/src/soc/qualcomm/sc7180/usb.c +++ b/src/soc/qualcomm/sc7180/usb.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <console/console.h> -#include <delay.h> #include <device/mmio.h> #include <soc/usb.h> #include <soc/clock.h> diff --git a/src/superio/aspeed/common/early_config.c b/src/superio/aspeed/common/early_config.c index fe780ff..b0aab89 100644 --- a/src/superio/aspeed/common/early_config.c +++ b/src/superio/aspeed/common/early_config.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <arch/io.h> -#include <delay.h> #include <device/pnp_def.h> #include <device/pnp_ops.h> #include <stdint.h>