Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel. Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 )
Change subject: wifi: Add support for new SAR tables revisions ......................................................................
Patch Set 18:
(1 comment)
File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/56750/comment/d17b3799_e8f243b5 PS17, Line 138: if (CONFIG(USE_SAR)) { : sar_limits->sar_table->version = 0; : sar_limits->sar_table->sar_enable = CONFIG(SAR_ENABLE); : sar_limits->sar_table->dsar_enable = CONFIG(DSAR_ENABLE); : sar_limits->sar_table->dsar_set_num = CONFIG_DSAR_SET_NUM; : }
What is the current size of the hex file? I am guessing it would be higher than 119 given that we ar […]
The generated .hex file size varies based on the following revision choosen in config.star sar_table_revision wgds_revision ant_table_revision wtas_revision https://chrome-internal-review.googlesource.com/c/chromeos/project/brya/brya... https://chrome-internal-review.googlesource.com/c/chromeos/project/brya/brya... https://chrome-internal-review.googlesource.com/c/chromeos/project/brya/brya... https://chrome-internal-review.googlesource.com/c/chromeos/project/brya/brya...
Following are the all different combinations that are possible with their corresponding generated .hex file size. eg: 2110 in the list indicate sar_table_revision = 2 wgds_revision = 1 ant_table_revision = 1 wtas_revision = 0
f indicating that the developer didn't choose to configure one of the table and scripts automatically added an invalid revision in the .hex file so that handling of that block is skipped by the revision check like the following. https://review.coreboot.org/c/coreboot/+/56750/18/src/drivers/wifi/generic/a...
Among the possible new .hex file size 119 and 81 is not possible.
[SAR|WGDS|PPAM|WTAS] - Str hex size ffff - 75 fff0 - 111 ff0f - 101 ff00 - 137 ff1f - 125 ff10 - 161 f0ff - 115 f0f0 - 151 f00f - 141 f000 - 177 f01f - 165 f010 - 201 f1ff - 133 f1f0 - 169 f10f - 159 f100 - 195 f11f - 183 f110 - 219 0fff - 161 0ff0 - 197 0f0f - 187 0f00 - 223 0f1f - 211 0f10 - 247 00ff - 201 00f0 - 237 000f - 227 0000 - 263 001f - 251 0010 - 287 01ff - 219 01f0 - 255 010f - 245 0100 - 281 011f - 269 0110 - 305 1fff - 257 1ff0 - 293 1f0f - 283 1f00 - 319 1f1f - 307 1f10 - 343 10ff - 297 10f0 - 333 100f - 323 1000 - 359 101f - 347 1010 - 383 11ff - 315 11f0 - 351 110f - 341 1100 - 377 111f - 365 1110 - 401 2fff - 433 2ff0 - 469 2f0f - 459 2f00 - 495 2f1f - 483 2f10 - 519 20ff - 473 20f0 - 509 200f - 499 2000 - 535 201f - 523 2010 - 559 21ff - 491 21f0 - 527 210f - 517 2100 - 553 211f - 541 2110 - 577
-
Sugnan Prabhu S (Code Review)