Change in coreboot[master]: mb/google/{daisy,veyron{_mickey,_rialto}}: Remove unused 'include <vb...
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41684 )
Change subject: mb/google/{daisy,veyron{_mickey,_rialto}}: Remove unused 'include <vbe.h>' ......................................................................
mb/google/{daisy,veyron{_mickey,_rialto}}: Remove unused 'include <vbe.h>'
Change-Id: I7c0be437e8cb49934913563c6d21056034a50095 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/veyron/mainboard.c M src/mainboard/google/veyron_mickey/mainboard.c M src/mainboard/google/veyron_rialto/mainboard.c 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/41684/1
diff --git a/src/mainboard/google/daisy/mainboard.c b/src/mainboard/google/daisy/mainboard.c index de60024..2f07937 100644 --- a/src/mainboard/google/daisy/mainboard.c +++ b/src/mainboard/google/daisy/mainboard.c @@ -18,7 +18,6 @@ #include <soc/tmu.h> #include <soc/usb.h> #include <symbols.h> -#include <vbe.h>
#include "exynos5250.h"
diff --git a/src/mainboard/google/veyron/mainboard.c b/src/mainboard/google/veyron/mainboard.c index 60c9737..b270466 100644 --- a/src/mainboard/google/veyron/mainboard.c +++ b/src/mainboard/google/veyron/mainboard.c @@ -16,7 +16,6 @@ #include <soc/spi.h> #include <soc/i2c.h> #include <symbols.h> -#include <vbe.h> #include <vendorcode/google/chromeos/chromeos.h>
#include "board.h" diff --git a/src/mainboard/google/veyron_mickey/mainboard.c b/src/mainboard/google/veyron_mickey/mainboard.c index f9feb2f..2567249 100644 --- a/src/mainboard/google/veyron_mickey/mainboard.c +++ b/src/mainboard/google/veyron_mickey/mainboard.c @@ -15,7 +15,6 @@ #include <soc/spi.h> #include <soc/i2c.h> #include <symbols.h> -#include <vbe.h> #include <vendorcode/google/chromeos/chromeos.h>
#include "board.h" diff --git a/src/mainboard/google/veyron_rialto/mainboard.c b/src/mainboard/google/veyron_rialto/mainboard.c index 1a5a944..9a9ce79 100644 --- a/src/mainboard/google/veyron_rialto/mainboard.c +++ b/src/mainboard/google/veyron_rialto/mainboard.c @@ -16,7 +16,6 @@ #include <soc/spi.h> #include <soc/i2c.h> #include <symbols.h> -#include <vbe.h> #include <vendorcode/google/chromeos/chromeos.h> #include <security/vboot/vboot_common.h>
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41684 )
Change subject: mb/google/{daisy,veyron{_mickey,_rialto}}: Remove unused 'include <vbe.h>' ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41684 )
Change subject: mb/google/{daisy,veyron{_mickey,_rialto}}: Remove unused 'include <vbe.h>' ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41684 )
Change subject: mb/google/{daisy,veyron{_mickey,_rialto}}: Remove unused 'include <vbe.h>' ......................................................................
mb/google/{daisy,veyron{_mickey,_rialto}}: Remove unused 'include <vbe.h>'
Change-Id: I7c0be437e8cb49934913563c6d21056034a50095 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41684 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/veyron/mainboard.c M src/mainboard/google/veyron_mickey/mainboard.c M src/mainboard/google/veyron_rialto/mainboard.c 4 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/daisy/mainboard.c b/src/mainboard/google/daisy/mainboard.c index de60024..2f07937 100644 --- a/src/mainboard/google/daisy/mainboard.c +++ b/src/mainboard/google/daisy/mainboard.c @@ -18,7 +18,6 @@ #include <soc/tmu.h> #include <soc/usb.h> #include <symbols.h> -#include <vbe.h>
#include "exynos5250.h"
diff --git a/src/mainboard/google/veyron/mainboard.c b/src/mainboard/google/veyron/mainboard.c index 60c9737..b270466 100644 --- a/src/mainboard/google/veyron/mainboard.c +++ b/src/mainboard/google/veyron/mainboard.c @@ -16,7 +16,6 @@ #include <soc/spi.h> #include <soc/i2c.h> #include <symbols.h> -#include <vbe.h> #include <vendorcode/google/chromeos/chromeos.h>
#include "board.h" diff --git a/src/mainboard/google/veyron_mickey/mainboard.c b/src/mainboard/google/veyron_mickey/mainboard.c index f9feb2f..2567249 100644 --- a/src/mainboard/google/veyron_mickey/mainboard.c +++ b/src/mainboard/google/veyron_mickey/mainboard.c @@ -15,7 +15,6 @@ #include <soc/spi.h> #include <soc/i2c.h> #include <symbols.h> -#include <vbe.h> #include <vendorcode/google/chromeos/chromeos.h>
#include "board.h" diff --git a/src/mainboard/google/veyron_rialto/mainboard.c b/src/mainboard/google/veyron_rialto/mainboard.c index 1a5a944..9a9ce79 100644 --- a/src/mainboard/google/veyron_rialto/mainboard.c +++ b/src/mainboard/google/veyron_rialto/mainboard.c @@ -16,7 +16,6 @@ #include <soc/spi.h> #include <soc/i2c.h> #include <symbols.h> -#include <vbe.h> #include <vendorcode/google/chromeos/chromeos.h> #include <security/vboot/vboot_common.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41684 )
Change subject: mb/google/{daisy,veyron{_mickey,_rialto}}: Remove unused 'include <vbe.h>' ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4612 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4611 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4610 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4609
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)