Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82246?usp=email )
Change subject: mb/system76/tgl: Update VBTs to version 250 ......................................................................
mb/system76/tgl: Update VBTs to version 250
Commit 4c7e97b26a34 ("Update fsp submodule to upstream master branch") included an update to the VBT from 240 to 250, breaking parsing of existing VBTs.
After that commit, the VBT was parsed as (from gaze16-3060-b):
[DEBUG] PCI: 00:02.0 init [INFO ] GMA: Found VBT in CBFS [INFO ] GMA: Found valid VBT in CBFS [INFO ] framebuffer_info: bytes_per_line: 4096, bits_per_pixel: 32 [INFO ] x_res x y_res: 1024 x 768, size: 3145728 at 0xd0000000 [DEBUG] PCI: 00:02.0 init finished in 6 msecs
When the expected output is:
[DEBUG] PCI: 00:00:02.0 init [INFO ] GMA: Found VBT in CBFS [INFO ] GMA: Found valid VBT in CBFS [INFO ] framebuffer_info: bytes_per_line: 7680, bits_per_pixel: 32 [INFO ] x_res x y_res: 1920 x 1080, size: 8294400 at 0xd0000000 [DEBUG] PCI: 00:00:02.0 init finished in 6 msecs
Generate blobs for the new version using Intel Display Configuration Tool (DisCon) v3.3, based on the existing 237 and 240 VBTs.
(For our edk2 payload, the UEFI GOP driver was updated to 17.0.1077.)
Tested on all affected systems:
- darp7 - galp5 - gaze16-3050 - gaze16-3060 - gaze16-3060-b - lemp10 - oryp8
Tested:
- Boot splash displays on screen again - Firmware setup menu is rendered, at correct resolution
Change-Id: I918356d9f660b985ee4408ef77544fbd071ab35f Signed-off-by: Tim Crawford tcrawford@system76.com Tested-by: Daniel Sutton daniel@system76.com Tested-by: Jacob Kauffmann jacob@system76.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/82246 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de --- M src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt M src/mainboard/system76/tgl-h/variants/gaze16-3060/data.vbt M src/mainboard/system76/tgl-h/variants/oryp8/data.vbt M src/mainboard/system76/tgl-u/variants/darp7/data.vbt M src/mainboard/system76/tgl-u/variants/galp5/data.vbt M src/mainboard/system76/tgl-u/variants/lemp10/data.vbt 6 files changed, 0 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt b/src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt index 2975227..ff4bbb6 100644 --- a/src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt +++ b/src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt Binary files differ diff --git a/src/mainboard/system76/tgl-h/variants/gaze16-3060/data.vbt b/src/mainboard/system76/tgl-h/variants/gaze16-3060/data.vbt index 2531c7a..5ff5bd5 100644 --- a/src/mainboard/system76/tgl-h/variants/gaze16-3060/data.vbt +++ b/src/mainboard/system76/tgl-h/variants/gaze16-3060/data.vbt Binary files differ diff --git a/src/mainboard/system76/tgl-h/variants/oryp8/data.vbt b/src/mainboard/system76/tgl-h/variants/oryp8/data.vbt index 5641c17..4165da8 100644 --- a/src/mainboard/system76/tgl-h/variants/oryp8/data.vbt +++ b/src/mainboard/system76/tgl-h/variants/oryp8/data.vbt Binary files differ diff --git a/src/mainboard/system76/tgl-u/variants/darp7/data.vbt b/src/mainboard/system76/tgl-u/variants/darp7/data.vbt index e3b164f..bb40901 100644 --- a/src/mainboard/system76/tgl-u/variants/darp7/data.vbt +++ b/src/mainboard/system76/tgl-u/variants/darp7/data.vbt Binary files differ diff --git a/src/mainboard/system76/tgl-u/variants/galp5/data.vbt b/src/mainboard/system76/tgl-u/variants/galp5/data.vbt index e3b164f..bb40901 100644 --- a/src/mainboard/system76/tgl-u/variants/galp5/data.vbt +++ b/src/mainboard/system76/tgl-u/variants/galp5/data.vbt Binary files differ diff --git a/src/mainboard/system76/tgl-u/variants/lemp10/data.vbt b/src/mainboard/system76/tgl-u/variants/lemp10/data.vbt index 7c29ced..2b1005b 100644 --- a/src/mainboard/system76/tgl-u/variants/lemp10/data.vbt +++ b/src/mainboard/system76/tgl-u/variants/lemp10/data.vbt Binary files differ
-
Felix Singer (Code Review)