Change in coreboot[master]: arch/riscv: Use same indents for switch/case

[Felix Singer (Code Review)]

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49203 )

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

arch/riscv: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I004103113e4002dded95f804d44bab7c7c4e7c43
Signed-off-by: Felix Singer 
---
M src/arch/riscv/trap_handler.c
1 file changed, 29 insertions(+), 29 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/49203/1

diff --git a/src/arch/riscv/trap_handler.c b/src/arch/riscv/trap_handler.c
index 32b2c40..6147a20 100644
--- a/src/arch/riscv/trap_handler.c
+++ b/src/arch/riscv/trap_handler.c
@@ -32,10 +32,10 @@
 static const char *mstatus_to_previous_mode(uintptr_t ms)
 {
    switch (ms & MSTATUS_MPP) {
-		case 0x00000000: return "user";
-		case 0x00000800: return "supervisor";
-		case 0x00001000: return "hypervisor";
-		case 0x00001800: return "machine";
+	case 0x00000000: return "user";
+	case 0x00000800: return "supervisor";
+	case 0x00001000: return "hypervisor";
+	case 0x00001800: return "machine";
    }

return "unknown";
@@ -116,31 +116,31 @@
    }

switch (tf->cause) {
-		case CAUSE_MISALIGNED_FETCH:
-		case CAUSE_FETCH_ACCESS:
-		case CAUSE_ILLEGAL_INSTRUCTION:
-		case CAUSE_BREAKPOINT:
-		case CAUSE_LOAD_ACCESS:
-		case CAUSE_STORE_ACCESS:
-		case CAUSE_USER_ECALL:
-		case CAUSE_HYPERVISOR_ECALL:
-		case CAUSE_MACHINE_ECALL:
-			print_trap_information(tf);
-			break;
-		case CAUSE_SUPERVISOR_ECALL:
-			handle_sbi(tf);
-			return;
-		case CAUSE_MISALIGNED_LOAD:
-		case CAUSE_MISALIGNED_STORE:
-			print_trap_information(tf);
-			handle_misaligned(tf);
-			return;
-		default:
-			printk(BIOS_EMERG, "================================\n");
-			printk(BIOS_EMERG, "coreboot: can not handle a trap:\n");
-			printk(BIOS_EMERG, "================================\n");
-			print_trap_information(tf);
-			break;
+	case CAUSE_MISALIGNED_FETCH:
+	case CAUSE_FETCH_ACCESS:
+	case CAUSE_ILLEGAL_INSTRUCTION:
+	case CAUSE_BREAKPOINT:
+	case CAUSE_LOAD_ACCESS:
+	case CAUSE_STORE_ACCESS:
+	case CAUSE_USER_ECALL:
+	case CAUSE_HYPERVISOR_ECALL:
+	case CAUSE_MACHINE_ECALL:
+		print_trap_information(tf);
+		break;
+	case CAUSE_SUPERVISOR_ECALL:
+		handle_sbi(tf);
+		return;
+	case CAUSE_MISALIGNED_LOAD:
+	case CAUSE_MISALIGNED_STORE:
+		print_trap_information(tf);
+		handle_misaligned(tf);
+		return;
+	default:
+		printk(BIOS_EMERG, "================================\n");
+		printk(BIOS_EMERG, "coreboot: can not handle a trap:\n");
+		printk(BIOS_EMERG, "================================\n");
+		print_trap_information(tf);
+		break;
    }

die("Can't recover from trap. Halting.\n");

[Angel Pons (Code Review)]

Attention is currently required from:  Felix Singer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49203 )

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Attention is currently required from:  Felix Singer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49203 )

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

Patch Set 1: -Code-Review

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49203 )

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
Angel, anything wrong on this one?

[Philipp Hug (Code Review)]

Attention is currently required from:  Felix Singer.
Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49203 )

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

Patch Set 2: Code-Review+2

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49203 )

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

Patch Set 2:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/49203/comment/3c63767b_761d3d8f 
PS2, Line 8: 
waiting for follow-ups.

Patchset:

PS1:
> Angel, anything wrong on this one?

I think he dropped his +2 because of the discussion in the follow-ups. I will leave a todo here so that this is clear.

Patchset:

PS2: 
I thin

[Angel Pons (Code Review)]

Attention is currently required from:  Felix Singer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49203 )

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS1:
> I think he dropped his +2 because of the discussion in the follow-ups. […]

I did.

[Felix Singer (Code Review)]

Hello build bot (Jenkins), Philipp Hug, Angel Pons, ron minnich,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49203

to look at the new patch set (#5).

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

arch/riscv: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I004103113e4002dded95f804d44bab7c7c4e7c43
Signed-off-by: Felix Singer 
---
M src/arch/riscv/trap_handler.c
1 file changed, 29 insertions(+), 29 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/49203/5

[Felix Singer (Code Review)]

Hello build bot (Jenkins), Philipp Hug, Angel Pons, ron minnich,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49203

to look at the new patch set (#6).

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

arch/riscv: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I004103113e4002dded95f804d44bab7c7c4e7c43
Signed-off-by: Felix Singer 
---
M src/arch/riscv/trap_handler.c
1 file changed, 29 insertions(+), 29 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/49203/6

[Felix Singer (Code Review)]

Hello build bot (Jenkins), Philipp Hug, Angel Pons, ron minnich,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49203

to look at the new patch set (#7).

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

arch/riscv: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I004103113e4002dded95f804d44bab7c7c4e7c43
Signed-off-by: Felix Singer 
---
M src/arch/riscv/trap_handler.c
1 file changed, 29 insertions(+), 29 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/49203/7

[M] Change in coreboot[master]: arch/riscv: Use same indents for switch/case

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49203?usp=email )

Change subject: arch/riscv: Use same indents for switch/case
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.