Attention is currently required from: Jason Nien, Martin Roth, Martin Roth, Matt DeVillier, Nico Huber, Paul Menzel.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78406?usp=email )
Change subject: mb/google/kahlee: Select SOC_AMD_COMMON_BLOCK_GRAPHICS_ACP
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
is this a function of the board or the SoC? If the latter, we can move this selection there
board. Devices with HDA don't need this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78406?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I51527a1bfae3e12ce5cf1da8a3465bbc9ddfa76e
Gerrit-Change-Number: 78406
Gerrit-PatchSet: 8
Gerrit-Owner: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 17 Oct 2023 19:05:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment