Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37727 )
Change subject: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37727/1/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37727/1/src/mainboard/asus/f2a85-m/... PS1, Line 71: /* enable SIO LPC decode */
already done in bootblock_soc_early_init()
Done
https://review.coreboot.org/c/coreboot/+/37727/1/src/mainboard/asus/f2a85-m/... PS1, Line 77: /* enable serial decode */
already done in hudson_lpc_decode()
Done
https://review.coreboot.org/c/coreboot/+/37727/1/src/mainboard/asus/f2a85-m/... PS1, Line 84: /* enable SB MMIO space */
already done in bootblock_soc_early_init() […]
Done
https://review.coreboot.org/c/coreboot/+/37727/1/src/mainboard/asus/f2a85-m/... PS1, Line 96: /* turn on secondary smbus at b20 */
Leave the rest about smbus to romstage.c, not needed for bootblock.
Done
https://review.coreboot.org/c/coreboot/+/37727/3/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/romstage.c:
https://review.coreboot.org/c/coreboot/+/37727/3/src/mainboard/asus/f2a85-m/... PS3, Line 79: superio_init_m(); 48mhzout and superio_init moved to bootblock, remove functions in this file.
-
Kyösti Mälkki (Code Review)