Attention is currently required from: Angel Pons, Michał Żygowski, Máté Kukri, Stefan Reinauer.
Michael Büchler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email )
Change subject: mb/dell: Add OptiPlex 7020/9020 port
......................................................................
Patch Set 25: Code-Review+1
(2 comments)
Patchset:
PS25:
Thank you for your work on this port! I tested this on a 9020 mini tower (MT). See my comment on the PCI(e) slots. Except that, all seems to work, but I did not test extensively. It boots with both a Haswell and a Broadwell mrc.bin.
I hope it's okay to give it a +1 as a non-regular contributor.
File src/mainboard/dell/optiplex_9020/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55232/comment/5a231d7c_6001ad7d :
PS25, Line 39: device pci 1c.1 off end
:
The mini tower (MT) variant has two additional slots compared to the UFF variant:
* 1c.1: PCI (through a bridge chip: Texas Instruments XIO2001)
* 1c.2: PCIe x1
I enabled the two marked devices for a local build and both slots then work. Maybe introduce variants with an overridetree.cb?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55232?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a
Gerrit-Change-Number: 55232
Gerrit-PatchSet: 25
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 01 Sep 2023 09:53:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment