EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39497 )
Change subject: ec/google/wilco: Store LID status into LIDS ......................................................................
ec/google/wilco: Store LID status into LIDS
Store LID status into LIDS. Then Intel driver can reference it.
TEST=check LID status by evtest
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ifdac938730eac034b626aa8ad9d52462f65137ba --- M src/ec/google/wilco/acpi/ec.asl M src/ec/google/wilco/acpi/lid.asl 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/39497/1
diff --git a/src/ec/google/wilco/acpi/ec.asl b/src/ec/google/wilco/acpi/ec.asl index 8fcd0dd..fddd730 100644 --- a/src/ec/google/wilco/acpi/ec.asl +++ b/src/ec/google/wilco/acpi/ec.asl @@ -60,6 +60,9 @@
/* Initialize UCSI */ ^UCSI.INIT () + + // Initialize LID switch state + Store (R (P1LC), \LIDS) }
/* diff --git a/src/ec/google/wilco/acpi/lid.asl b/src/ec/google/wilco/acpi/lid.asl index 818e135..b85b7aa 100644 --- a/src/ec/google/wilco/acpi/lid.asl +++ b/src/ec/google/wilco/acpi/lid.asl @@ -22,6 +22,7 @@
Method (_LID, 0, NotSerialized) { - Return (R (P1LC)) + Store (R (P1LC), \LIDS) + Return (\LIDS) } }
Hello build bot (Jenkins), Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39497
to look at the new patch set (#2).
Change subject: ec/google/wilco: Store LID status into LIDS and change device name ......................................................................
ec/google/wilco: Store LID status into LIDS and change device name
Store LID status into LIDS and change device name to LID0. Then Intel driver can reference it.
BUG=b:151134069 TEST=check LID status by evtest
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ifdac938730eac034b626aa8ad9d52462f65137ba --- M src/ec/google/wilco/acpi/ec.asl M src/ec/google/wilco/acpi/event.asl M src/ec/google/wilco/acpi/lid.asl 3 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/39497/2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39497 )
Change subject: ec/google/wilco: Store LID status into LIDS and change device name ......................................................................
Patch Set 2: Code-Review+2
I'm not sure LIDS is actually getting used but it doesn't hurt to be consistent with other implementations.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39497 )
Change subject: ec/google/wilco: Store LID status into LIDS and change device name ......................................................................
ec/google/wilco: Store LID status into LIDS and change device name
Store LID status into LIDS and change device name to LID0. Then Intel driver can reference it.
BUG=b:151134069 TEST=check LID status by evtest
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ifdac938730eac034b626aa8ad9d52462f65137ba Reviewed-on: https://review.coreboot.org/c/coreboot/+/39497 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/ec/google/wilco/acpi/ec.asl M src/ec/google/wilco/acpi/event.asl M src/ec/google/wilco/acpi/lid.asl 3 files changed, 7 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/ec/google/wilco/acpi/ec.asl b/src/ec/google/wilco/acpi/ec.asl index 8fcd0dd..fddd730 100644 --- a/src/ec/google/wilco/acpi/ec.asl +++ b/src/ec/google/wilco/acpi/ec.asl @@ -60,6 +60,9 @@
/* Initialize UCSI */ ^UCSI.INIT () + + // Initialize LID switch state + Store (R (P1LC), \LIDS) }
/* diff --git a/src/ec/google/wilco/acpi/event.asl b/src/ec/google/wilco/acpi/event.asl index f6534d3..8f6a123 100644 --- a/src/ec/google/wilco/acpi/event.asl +++ b/src/ec/google/wilco/acpi/event.asl @@ -57,7 +57,7 @@ /* LID state changed */ If (EBIT (E1LD, Arg0)) { Printf ("Lid State Changed") - Notify (^LID, 0x80) + Notify (^LID0, 0x80) }
/* Power Event */ diff --git a/src/ec/google/wilco/acpi/lid.asl b/src/ec/google/wilco/acpi/lid.asl index 818e135..1697e1d 100644 --- a/src/ec/google/wilco/acpi/lid.asl +++ b/src/ec/google/wilco/acpi/lid.asl @@ -14,7 +14,7 @@ * GNU General Public License for more details. */
-Device (LID) +Device (LID0) { Name (_HID, EisaId ("PNP0C0D")) Name (_UID, 1) @@ -22,6 +22,7 @@
Method (_LID, 0, NotSerialized) { - Return (R (P1LC)) + Store (R (P1LC), \LIDS) + Return (\LIDS) } }
-
Duncan Laurie (Code Review) -
EricR Lai (Code Review)
-
Patrick Georgi (Code Review)