Attention is currently required from: Rex-BC Chen. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59294 )
Change subject: soc/mediatek/mt8186: add early initialization for eMMC ......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8186/msdc.c:
https://review.coreboot.org/c/coreboot/+/59294/comment/4dfa4c00_c6dfb4f0 PS2, Line 62: mtk_emmc_early_init((void *)MSDC0_BASE, (void *)MSDC0_TOP_BASE); give this is a board-specific feature (e.g., some boards may prefer to not do early init, if they don't use depthcharge) I think this should invoked from mainboard.c, of change the function to mtk_msdc_configure_emmc(int early_init) and only do early_init if the param is 1.