Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Arthur Heymans, Elyes Haouas, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66263 )
Change subject: soc/intel/meteorlake: Fix incompatible function pointers
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/meteorlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162440):
https://review.coreboot.org/c/coreboot/+/66263/comment/daa6d0f7_07735c24
PS4, Line 423: void (*fill_fsps_params[])(FSP_S_CONFIG *s_cfg,
need consistent spacing around '*' (ctx:WxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia00706b9cd718e590819621986dbd20555f6c226
Gerrit-Change-Number: 66263
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 04 Nov 2022 18:25:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment