Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/24989
Change subject: google/cyan: fix ACPI interrupt triggering for audio codecs ......................................................................
google/cyan: fix ACPI interrupt triggering for audio codecs
Adjust GpioInt trigger type for both LPEA and audio codec to match Intel CHT reference code. Fixes jack detection under Windows.
Test: boot Windows on google/egdar, observe headphone insertion/ removal produces audio output on the expected device.
Change-Id: Ic1dd8ece610d761791c060ece2d0aa51addf97ad Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/cyan/acpi/codec_maxim.asl M src/mainboard/google/cyan/acpi/codec_realtek.asl 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/24989/1
diff --git a/src/mainboard/google/cyan/acpi/codec_maxim.asl b/src/mainboard/google/cyan/acpi/codec_maxim.asl index 9abc91e..f805ea1 100644 --- a/src/mainboard/google/cyan/acpi/codec_maxim.asl +++ b/src/mainboard/google/cyan/acpi/codec_maxim.asl @@ -47,7 +47,7 @@ "\_SB.PCI0.I2C2", /* ResourceSource: I2C bus controller name */ )
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,, + GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullNone,, "\_SB.GPSE") { BOARD_JACK_MAXIM_GPIO_INDEX } } ) Return (SBUF) @@ -91,7 +91,7 @@ "\_SB.PCI0.I2C2", /* ResourceSource: I2C bus controller name */ )
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,, + GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullNone,, "\_SB.GPSW") { BOARD_JACK_TI_GPIO_INDEX }
} ) @@ -111,7 +111,7 @@ Name (GBUF, ResourceTemplate () { /* Jack Detect (index 0) */ - GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,, + GpioInt (Edge, ActiveBoth, ExclusiveAndWake, PullNone,, "\_SB.GPSE") { BOARD_JACK_MAXIM_GPIO_INDEX } }) } diff --git a/src/mainboard/google/cyan/acpi/codec_realtek.asl b/src/mainboard/google/cyan/acpi/codec_realtek.asl index d3fa84e..35aa64d 100644 --- a/src/mainboard/google/cyan/acpi/codec_realtek.asl +++ b/src/mainboard/google/cyan/acpi/codec_realtek.asl @@ -39,7 +39,7 @@ )
/* Jack Detect (index 0) */ - GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,, + GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullNone,, "\_SB.GPSW") { JACK_DETECT_GPIO_INDEX } } ) Return (SBUF) @@ -57,7 +57,7 @@ Name (GBUF, ResourceTemplate () { /* Jack Detect (index 0) */ - GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,, + GpioInt (Edge, ActiveBoth, ExclusiveAndWake, PullNone,, "\_SB.GPSW") { JACK_DETECT_GPIO_INDEX } }) }