Change in coreboot[master]: cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44322 )

Change subject: cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4
......................................................................

cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4

The SMM_ASEG code only supports up to 4 CPUs, so assert this at
buildtime.

Change-Id: I8ec803cd1b76f17f4dccd5c573179d542d54c277
Signed-off-by: Arthur Heymans 
---
M src/cpu/x86/smm/smm.ld
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/44322/1

diff --git a/src/cpu/x86/smm/smm.ld b/src/cpu/x86/smm/smm.ld
index af5968d..2f46975 100644
--- a/src/cpu/x86/smm/smm.ld
+++ b/src/cpu/x86/smm/smm.ld
@@ -2,6 +2,9 @@

/* Maximum number of CPUs/cores */
 CPUS = 4;
+
+_ = ASSERT(CPUS > CONFIG_MAX_CPUS, "The ASEG SMM code only supports up to 4 CPUS");
+
 ENTRY(smm_handler_start);

SECTIONS

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44322

to look at the new patch set (#3).

Change subject: cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4
......................................................................

cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4

The SMM_ASEG code only supports up to 4 CPUs, so assert this at
buildtime.

Change-Id: I8ec803cd1b76f17f4dccd5c573179d542d54c277
Signed-off-by: Arthur Heymans 
---
M src/cpu/x86/smm/smm.ld
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/44322/3

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44322 )

Change subject: cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4
......................................................................

Patch Set 3: Code-Review+2

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins), Angel Pons, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44322

to look at the new patch set (#7).

Change subject: cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4
......................................................................

cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4

The SMM_ASEG code only supports up to 4 CPUs, so assert this at
buildtime.

Change-Id: I8ec803cd1b76f17f4dccd5c573179d542d54c277
Signed-off-by: Arthur Heymans 
---
M src/cpu/x86/smm/smm.ld
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/44322/7

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins), Angel Pons, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44322

to look at the new patch set (#8).

Change subject: cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4
......................................................................

cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4

The SMM_ASEG code only supports up to 4 CPUs, so assert this at
buildtime.

Change-Id: I8ec803cd1b76f17f4dccd5c573179d542d54c277
Signed-off-by: Arthur Heymans 
---
M src/cpu/x86/smm/smm.ld
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/44322/8

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44322 )

Change subject: cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4
......................................................................

cpu/x86/smm/smm.ld: Assert that CONFIG_MAX_CPUS <= 4

The SMM_ASEG code only supports up to 4 CPUs, so assert this at
buildtime.

Change-Id: I8ec803cd1b76f17f4dccd5c573179d542d54c277
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44322
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/cpu/x86/smm/smm.ld
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/cpu/x86/smm/smm.ld b/src/cpu/x86/smm/smm.ld
index af5968d..e232028 100644
--- a/src/cpu/x86/smm/smm.ld
+++ b/src/cpu/x86/smm/smm.ld
@@ -2,6 +2,9 @@

/* Maximum number of CPUs/cores */
 CPUS = 4;
+
+_ = ASSERT(CPUS >= CONFIG_MAX_CPUS, "The ASEG SMM code only supports up to 4 CPUS");
+
 ENTRY(smm_handler_start);

SECTIONS