Attention is currently required from: Kane Chen, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64467 )
Change subject: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Patchset:
PS3:
Please
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/64467/comment/baf62557_39a2cc1d
PS3, Line 339: lapicid
Use a variable instead of calling this over and over...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64467
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1
Gerrit-Change-Number: 64467
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:19:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment