Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59585 )
Change subject: soc/amd/*: PSP verstage minbuild
......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/common/psp_verstage/Kconfig:
https://review.coreboot.org/c/coreboot/+/59585/comment/fefe212b_3eafaccb
PS2, Line 21: !VBOOT
Shouldn't it depend on `!VBOOT`? I assume, if one would have VBOOT on and this too,
we'd still (have to) build the full psp verstage, so why show the option in this case?
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/59585/comment/3d04e8d9_a2674186
PS2, Line 292: VBOOT_STARTS_BEFORE_BOOTBLOCK
Shouldn't this just check for `CONFIG(VBOOT)`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie506193d21207ecabe65158e84dc02eec1cf5b26
Gerrit-Change-Number: 59585
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 21 Dec 2021 13:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment