Attention is currently required from: Julius Werner, Martin L Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75031?usp=email )
Change subject: util/xcompile: Add target architecture to CPPFLAGS
......................................................................
Patch Set 12:
(2 comments)
File src/arch/arm/armv4/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/75031/comment/a71357fc_5035c8c9 :
PS11, Line 20: -target arm-eabi
Generally, I feel like this kind of stuff belongs in xcompile, not in the architecture Makefile. […]
Done
https://review.coreboot.org/c/coreboot/+/75031/comment/50755912_25d96f26 :
PS11, Line 34: verstage-ld-ccopts += -target arm-eabi
nit: this would probably look cleaner if it always came right after the generic-ccopts.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75031?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4340681e30059d6f18a49a49937668cd3dd39ce1
Gerrit-Change-Number: 75031
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 20 Mar 2024 13:40:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment