Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31321
Change subject: soc/intel/bdw: Remove spurious comment ......................................................................
soc/intel/bdw: Remove spurious comment
Change-Id: I45f2ca809a6acfcb80a742d29c045d04888e4d7f Signed-off-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/broadwell/bootblock/cpu.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31321/1
diff --git a/src/soc/intel/broadwell/bootblock/cpu.c b/src/soc/intel/broadwell/bootblock/cpu.c index 2d56f32..6e677d1 100644 --- a/src/soc/intel/broadwell/bootblock/cpu.c +++ b/src/soc/intel/broadwell/bootblock/cpu.c @@ -41,7 +41,6 @@ msr_t msr;
disable_cache(); - /* Why only top 4MiB ? */ set_var_mtrr(1, CACHE_ROM_BASE_C, CACHE_ROM_SIZE, MTRR_TYPE_WRPROT); enable_cache();
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31321 )
Change subject: soc/intel/bdw: Remove spurious comment ......................................................................
Patch Set 1: Code-Review+2
Hello Kyösti Mälkki, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31321
to look at the new patch set (#2).
Change subject: soc/intel/bdw: Remove spurious comment ......................................................................
soc/intel/bdw: Remove spurious comment
Change-Id: I45f2ca809a6acfcb80a742d29c045d04888e4d7f Signed-off-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/broadwell/bootblock/cpu.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31321/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31321 )
Change subject: soc/intel/bdw: Remove spurious comment ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31321 )
Change subject: soc/intel/bdw: Remove spurious comment ......................................................................
soc/intel/bdw: Remove spurious comment
Change-Id: I45f2ca809a6acfcb80a742d29c045d04888e4d7f Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/31321 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/bootblock/cpu.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/bootblock/cpu.c b/src/soc/intel/broadwell/bootblock/cpu.c index 7508bc2..2f1ac51 100644 --- a/src/soc/intel/broadwell/bootblock/cpu.c +++ b/src/soc/intel/broadwell/bootblock/cpu.c @@ -41,7 +41,6 @@ msr_t msr;
disable_cache(); - /* Why only top 4MiB ? */ set_var_mtrr(1, CACHE_ROM_BASE, CACHE_ROM_SIZE, MTRR_TYPE_WRPROT); enable_cache();
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)