Attention is currently required from: Felix Singer, Martin L Roth, Patrick Rudolph, Subrata Banik, Matt DeVillier, Stefan Reinauer, Kapil Porwal, Angel Pons, Lean Sheng Tan.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74692 )
Change subject: Revert "util/ifdtool: Add option to create FMAP template"
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74692/comment/745276ba_cca21da0
PS2, Line 11: Above commit inserts multiple IFD regions not present into the default
: FMAP template, some of which overlap, resulting in far less space
: available for BIOS region / CBFS.
I don't understand. why "not present"? It only inserts IFD regions that are present in the IFD.
The basic Idea is that all IFD regions (except BIOS region) are mapped to the FMAP to prevent overlaps. That can for example happen by increasing the CBFS_SIZE too much and therefore unintentionally overlapping the IFD/blob regions without noticing.
Did you have issues with an IFD on a board? Was the IFD faulty somehow?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cbcbe16d508787f5c8aae4889199185890f0dc7
Gerrit-Change-Number: 74692
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 24 Apr 2023 02:32:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment