Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Paweł Anikiel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78297?usp=email )
Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change ......................................................................
Patch Set 3:
(1 comment)
File src/drivers/wwan/fm/acpi_fm350gl.c:
https://review.coreboot.org/c/coreboot/+/78297/comment/1ad21421_ac7e7728 : PS3, Line 287: #if CONFIG(GENERIC_GPIO_LIB)
I needed to get the pin number and the GPIO controller's scope name from a `struct acpi_gpio`. I looked at the implementation of `acpi_device_write_gpio()`, because it writes out both of these things. This implementation uses lots of GENERIC_GPIO_LIB ifdefs, so I copied over exactly what it did.
Is there a better way of doing this? If so, I'll use it.
why not ``` if (CONFIG(GENERIC_GPIO_LIB)) pin = gpio_acpi_pin(pin); ```
what would happen when GENERIC_GPIO_LIB is not enabled? shouldn't u bail out early ?