[S] Change in coreboot[main]: cpu/x86: Conditionally invalidate caches based on self-snooping support

[Shuo Liu (Code Review)]

Attention is currently required from: Jérémy Compostella, Subrata Banik.

Shuo Liu has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87182?usp=email )

Change subject: cpu/x86: Conditionally invalidate caches based on self-snooping support
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/87182/comment/006e4b2d_7984bf6e?usp... :
PS2, Line 35:
> > Does arch_segment_loaded in cpu/x86/cache/cache.c needs to be handled as well? […]

I suppose not yet - https://github.com/coreboot/coreboot/blob/712dfc175979a85a9075e971b4674cce3e.... The callback arch_segment_loaded is not limited to CAR phase so maybe we still need to deal with it.

File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/87182/comment/46632a07_44e3ee90?usp... :
PS2, Line 831: 	if (!self_snooping_supported()) {
> > Do we need to check clflush_supported to do clflush over wbinvd? […]

Acknowledged