Change in coreboot[master]: mb/google/nightfury: Update tdp_pl1_override value

[shkim (Code Review)]

Hello SH Kim,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/40323

to review the following change.

Change subject: mb/google/nightfury: Update tdp_pl1_override value
......................................................................

mb/google/nightfury: Update tdp_pl1_override value

Update tdp_pl1_override value to 15W for CML-U based nightfury platform.

BUG=None
BRANCH=firmware-hatch-12672.B
TEST=Built

Signed-off-by: Seunghwan Kim 
Change-Id: Ib0155b961b9d304bed2e9456c4964ebd598af4dc
---
M src/mainboard/google/hatch/variants/nightfury/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/40323/1

diff --git a/src/mainboard/google/hatch/variants/nightfury/overridetree.cb b/src/mainboard/google/hatch/variants/nightfury/overridetree.cb
index a940f8b..4b985d9 100644
--- a/src/mainboard/google/hatch/variants/nightfury/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/nightfury/overridetree.cb
@@ -1,5 +1,5 @@
 chip soc/intel/cannonlake
-	register "tdp_pl1_override" = "8"
+	register "tdp_pl1_override" = "15"
    register "tdp_pl2_override" = "51"

register "SerialIoDevMode" = "{

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40323 )

Change subject: mb/google/nightfury: Update tdp_pl1_override value
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40323 )

Change subject: mb/google/nightfury: Update tdp_pl1_override value
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40323 )

Change subject: mb/google/nightfury: Update tdp_pl1_override value
......................................................................

mb/google/nightfury: Update tdp_pl1_override value

Update tdp_pl1_override value to 15W for CML-U based nightfury platform.

BUG=None
BRANCH=firmware-hatch-12672.B
TEST=Built

Signed-off-by: Seunghwan Kim 
Change-Id: Ib0155b961b9d304bed2e9456c4964ebd598af4dc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40323
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Patrick Georgi 
---
M src/mainboard/google/hatch/variants/nightfury/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/nightfury/overridetree.cb b/src/mainboard/google/hatch/variants/nightfury/overridetree.cb
index a940f8b..4b985d9 100644
--- a/src/mainboard/google/hatch/variants/nightfury/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/nightfury/overridetree.cb
@@ -1,5 +1,5 @@
 chip soc/intel/cannonlake
-	register "tdp_pl1_override" = "8"
+	register "tdp_pl1_override" = "15"
    register "tdp_pl2_override" = "51"

register "SerialIoDevMode" = "{

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40323 )

Change subject: mb/google/nightfury: Update tdp_pl1_override value
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2315
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2314
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2313

Please note: This test is under development and might not be accurate at all!