Change in ...coreboot[master]: sb/intel/lynxpoint: Ensure the finalise handler is called
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29976 )
Change subject: sb/intel/lynxpoint: Ensure the finalise handler is called ......................................................................
Patch Set 1:
(1 comment)
Patrick G., not sure if anybody @google still cares, but it seems like Lynx Point was missing the finalize trigger on the resume path all the time.
https://review.coreboot.org/#/c/29976/1/src/southbridge/intel/lynxpoint/lpc.... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/#/c/29976/1/src/southbridge/intel/lynxpoint/lpc.... PS1, Line 972: IS_ENABLED(CONFIG_HAVE_SMI_HANDLER) Should be selected by lynxpoint/Kconfig (instead of every single board. And no need to check here, then.
-
Nico Huber (Code Review)