build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41630 )
Change subject: soc/amd/picasso: rewrite soc_util
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41630/5/src/soc/amd/picasso/soc_uti...
File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/41630/5/src/soc/amd/picasso/soc_uti...
PS5, Line 50: if (silicon_type) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/41630/5/src/soc/amd/picasso/soc_uti...
PS5, Line 142: if (is_fam17_1x() && !is_mystery_silicon()) {
braces {} are not necessary for any arm of this statement
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I589be3bdac4b94785e6ecacf55235be4ad5673d9
Gerrit-Change-Number: 41630
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 May 2020 22:37:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment