Attention is currently required from: Fred Reitberger.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67300 )
Change subject: lib/xxhash.c: Add new hash functions ......................................................................
Patch Set 1:
(3 comments)
File src/lib/xxhash.c:
https://review.coreboot.org/c/coreboot/+/67300/comment/064c348a_a09e39a5 PS1, Line 7: * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) Don't need the full text here, that's what the SPDX tag is for.
https://review.coreboot.org/c/coreboot/+/67300/comment/2110c54e_5a8f247d PS1, Line 57: #endif unused?
https://review.coreboot.org/c/coreboot/+/67300/comment/3eda7c62_ec47d2a7 PS1, Line 90: if (IS_ALIGNED(up, 4)) { I don't think you want to do this, it's gonna kill your performance. The kernel code is designed (I think) to collapse to nothing on platforms that support unaligned accesses, but what you're doing here does not. Also, you are not actually honoring the le32 part in the aligned case here (remember we do have ppc64).
coreboot platforms always allow unaligned accesses, so I think you can just use le32toh()/le64toh() for these.
-
Julius Werner (Code Review)