Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50207 )
Change subject: soc/amd/picasso/pcie_gpe: use PICM instead of PMOD in APCI code ......................................................................
soc/amd/picasso/pcie_gpe: use PICM instead of PMOD in APCI code
commit 3f2467032e3e40cd456d2d9fe5120a60283784aa changed this in the APCI code itself, but the change in the ACPI byte code generation in pcie_gpp.c was missed and this patch fixes that.
TEST=Fixes the regression on Mandolin.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I60de29581296101947336f70343d6206af97e307 Reviewed-on: https://review.coreboot.org/c/coreboot/+/50207 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/soc/amd/picasso/pcie_gpp.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/picasso/pcie_gpp.c b/src/soc/amd/picasso/pcie_gpp.c index 3101eb4..00b32a0 100644 --- a/src/soc/amd/picasso/pcie_gpp.c +++ b/src/soc/amd/picasso/pcie_gpp.c @@ -127,9 +127,9 @@
acpigen_write_method("_PRT", 0);
- /* If (PMOD) */ + /* If (PICM) */ acpigen_write_if(); - acpigen_emit_namestring("PMOD"); + acpigen_emit_namestring("PICM");
/* Return (Package{...}) */ acpigen_emit_byte(RETURN_OP); @@ -192,7 +192,7 @@ * * Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table * { - * If (PMOD) + * If (PICM) * { * Return (Package (0x04) * {