Attention is currently required from: Lance Zhao, Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Archana Patni, Michael Niewöhner, Ronak Kanabar.
Hello Lance Zhao, build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Archana Patni, Michael Niewöhner, Ronak Kanabar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59790
to look at the new patch set (#5).
Change subject: mb/google/brya: Fix S0i3 regression
......................................................................
mb/google/brya: Fix S0i3 regression
Keeping the PM timer enabled will disqualify an ADL system from entering
S0i3, and will also cause an increase in power during suspend states.
The PM timer is not required for brya boards, therefore disabling it.
Fixes: 0e905801 (soc/intel: transition full control over PM Timer from
FSP to coreboot)
BUG=b:206922066
TEST=Boot gimble to OS and verify S0i3 counter incrementing after
exiting S0ix suspend states.
Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com
Change-Id: I8005dacd732c033980ccc479375ff5b06df8dac1
---
M src/mainboard/google/brya/Kconfig
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/59790/5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8005dacd732c033980ccc479375ff5b06df8dac1
Gerrit-Change-Number: 59790
Gerrit-PatchSet: 5
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Archana Patni
archana.patni@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Archana Patni
archana.patni@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-MessageType: newpatchset