Change in coreboot[master]: build: build the open-power ffs tools

[Marty E. Plummer (Code Review)]

Marty E. Plummer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35008 )

Change subject: build: build the open-power ffs tools
......................................................................

build: build the open-power ffs tools

Change-Id: I0ed8b8de001835e5676203c384a1659a2f29ff71
Signed-off-by: Marty E. Plummer 
---
M Makefile.inc
1 file changed, 17 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/35008/1

diff --git a/Makefile.inc b/Makefile.inc
index c275d1e..9ad0c59 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -515,6 +515,8 @@
 IFWITOOL:=$(objutil)/cbfstool/ifwitool
 IFITTOOL:=$(objutil)/cbfstool/ifittool
 AMDCOMPRESS:=$(objutil)/cbfstool/amdcompress
+FPART:=$(objutil)/ffs/fpart/fpart
+ECC:=$(objutil)/ffs/ecc/ecc

$(obj)/cbfstool: $(CBFSTOOL)
    cp $< $@
@@ -534,6 +536,21 @@
 $(obj)/amdcompress: $(AMDCOMPRESS)
    cp $< $@

+$(FPART):
+	mkdir -p $(objutil)/ffs
+	cd $(top)/3rdparty/ffs && autoreconf -i
+	cd $(objutil)/ffs && $(top)/3rdparty/ffs/configure CC="$(HOSTCC)" LD="$(LD)"
+	$(MAKE) -C $(objutil)/ffs
+
+$(ECC): $(FPART)
+	true
+
+$(obj)/fpart: $(FPART)
+	cp $< $@
+
+$(obj)/ecc: $(ECC)
+	cp $< $@
+
 _WINCHECK=$(shell uname -o 2> /dev/null)
 STACK=
 ifeq ($(_WINCHECK),Msys)

[Marty E. Plummer (Code Review)]

Marty E. Plummer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35008 )

Change subject: build: build the open-power ffs tools
......................................................................

Patch Set 1:

Having some slight issue here. Currently you need to manually
do `make build/fpart` to get this to work as the ffs tools do
not get built otherwise. Unsure how to do that.

[Timothy Pearson (Code Review)]

Timothy Pearson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35008 )

Change subject: build: build the open-power ffs tools
......................................................................

Patch Set 4: Code-Review+2

[Marty E. Plummer (Code Review)]

Marty E. Plummer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35008 )

Change subject: build: build the open-power ffs tools
......................................................................

Patch Set 4:

Actually, don't merge any of these ffs patches yet. I think I have
a better way of doin it.

[Timothy Pearson (Code Review)]

Timothy Pearson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35008 )

Change subject: build: build the open-power ffs tools
......................................................................

Patch Set 4: -Code-Review
> Patch Set 4:
>
> Actually, don't merge any of these ffs patches yet. I think I have
> a better way of doin it.

OK, in the future the best way to do that is to set -1/-2 on your own patches to block submission.  As it stands I'm trying to review OpenPOWER patches fairly rapidly to encourage development, so there's a high chance of things going through rapidly if I don't see problems with the patch sets (and they don't touch non-POWER parts of the tree).

[Marty E. Plummer (Code Review)]

Hello Timothy Pearson, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35008

to look at the new patch set (#6).

Change subject: build: build the open-power ffs tools
......................................................................

build: build the open-power ffs tools

Change-Id: I0ed8b8de001835e5676203c384a1659a2f29ff71
Signed-off-by: Marty E. Plummer 
---
M Makefile.inc
1 file changed, 22 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/35008/6

[Marty E. Plummer (Code Review)]

Marty E. Plummer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35008 )

Change subject: build: build the open-power ffs tools
......................................................................

Patch Set 6:
> Patch Set 4: -Code-Review
> > Patch Set 4:
> >
> > Actually, don't merge any of these ffs patches yet. I think I have
> > a better way of doin it.
>
> OK, in the future the best way to do that is to set -1/-2 on your own patches to block submission.  As it stands I'm trying to review OpenPOWER patches fairly rapidly to encourage development, so there's a high chance of things going through rapidly if I don't see problems with the patch sets (and they don't touch non-POWER parts of the tree).

Ok, noted. I've got it so that fpart is automatically built if you set
CONFIG_FFS_HEADERS and as far as I can see it does not impact non ppc64
builds.