Krystian Hebel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31620
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
util/superiotool/ite.c: add support for IT8613E
Based on not publicly available IT8613E Preliminary Specification V0.3.
Change-Id: Iec99d4d998f645dbad9c803d6d5477580b0bccc4 Signed-off-by: Krystian Hebel krystian.hebel@3mdeb.com --- M util/superiotool/ite.c 1 file changed, 65 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31620/1
diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c index 06efc57..eebcc0a 100644 --- a/util/superiotool/ite.c +++ b/util/superiotool/ite.c @@ -328,6 +328,40 @@ {0x19, "Power Channel 5", {0x30,0x60,0x61,0x62,0x63,0x70,0x71,EOT}, {0x00,0x00,0x7a,0x00,0x7c,0x01,0x01,EOT}}, + {0x8613, "IT8613E", { + {NOLDN, NULL, + {0x20,0x21,0x22,0x23,0x24,0x2b,EOT}, + {0x86,0x13,0x05,0x40,0x00,0x48,EOT}}, + {0x1, "COM1", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x03,0xf8,0x04,0x00,EOT}}, + {0x4, "Environment controller", + {0x30,0x60,0x61,0x62,0x63,0x70,0xf0,0xf1,0xf2,0xf3, + 0xf4,0xf5,0xf6,0xfa,0xfb,0xfc,EOT}, + {0x00,0x02,0x90,0x02,0x30,0x09,0x00,0x00,0x00,0x00, + 0x00,NANA,NANA,0x00,0x00,0x00,EOT}}, + {0x5, "Keyboard", + {0x30,0x60,0x61,0x62,0x63,0x70,0x71,0xf0,EOT}, + {0x01,0x00,0x60,0x00,0x64,0x01,0x02,0x48,EOT}}, + {0x6, "Mouse", + {0x30,0x70,0x71,0xf0,EOT}, + {0x00,0x0c,0x02,0x00,EOT}}, + {0x7, "GPIO", + {0x25,0x26,0x27,0x28,0x29,0x2a,0x2c,0x2d,0x60,0x61, + 0x62,0x63,0x70,0x71,0x72,0x73,0x74,0xb0,0xb1,0xb2, + 0xb3,0xb4,0xb8,0xba,0xbb,0xbc,0xbd,0xc0,0xc1,0xc2, + 0xc3,0xc4,0xc8,0xc9,0xca,0xcb,0xcc,0xcd,0xda,0xdb, + 0xe0,0xe1,0xe2,0xe3,0xe4,0xec,0xf0,0xf1,0xf2,0xf3, + 0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb,EOT}, + {0x00,0xF3,0x00,0x00,0x00,0x01,0x01,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x20,0x38,0x00,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01,0x00,0x00, + 0x40,0x00,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,0x00,0x0e,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0xa, "Consumer IR", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x03,0x10,0x0b,0x06,EOT}}, {EOT}}}, {0x8623, "IT8623E", { /* Defaults are not specified as no datasheet available */ @@ -1032,6 +1066,37 @@ };
static const struct superio_registers ec_table[] = { + {0x8613, "IT8613E", { + {NOLDN, NULL, + {0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09, + 0x0a,0x0b,0x0c,0x0e,0x0f,0x11,0x12,0x13,0x14,0x16, + 0x17,0x19,0x1a,0x1c,0x1d,0x1e,0x1f,0x20,0x21,0x22, + 0x24,0x25,0x27,0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2e, + 0x2f,0x30,0x31,0x32,0x33,0x34,0x35,0x38,0x39,0x3a, + 0x3b,0x40,0x41,0x42,0x43,0x44,0x45,0x46,0x47,0x50, + 0x51,0x52,0x53,0x54,0x55,0x56,0x57,0x58,0x59,0x5a, + 0x5b,0x5c,0x5d,0x5e,0x5f,0x68,0x69,0x6a,0x6b,0x6c, + 0x6d,0x6e,0x70,0x71,0x72,0x73,0x74,0x75,0x76,0x78, + 0x79,0x7a,0x7b,0x7c,0x7d,0x7e,0x80,0x81,0x82,0x83, + 0x84,0x85,0x86,0x87,0x88,0x89,0x8a,0x8b,0x8c,0x8d, + 0x8e,0x8f,0x90,0x91,0x98,0x99,0x9c,0x9d,0x9e,0x9f, + 0xa0,0xa1,0xa2,0xa3,0xa4,0xa5,0xa6,0xb4,0xb5,0xb6, + 0xb7,0xb8,0xb9,EOT}, + {0x18,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xC0, + 0x44,0x00,0x00,MISC,MISC,NANA,NANA,0x00,0x40,0x00, + 0x00,MISC,MISC,NANA,NANA,0x00,0x00,MISC,MISC,MISC, + MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC, + MISC,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA, + NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,0x00, + 0x00,0x7f,0x7f,0x7f,0x40,0x00,0x00,0x90,0x00,0x00, + 0x12,0x60,0x00,0x00,0x00,0x7f,0x7f,0x7f,0x00,0x00, + 0x7f,0x0f,0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f,0x7f, + 0x7f,0x7f,0x00,0x00,0x7f,0x0f,MISC,MISC,MISC,MISC, + NANA,NANA,NANA,NANA,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,MISC,0x00,0x00,0x00,0x00,0x00,NANA,0x00,NANA, + 0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f,NANA,NANA,NANA, + NANA,NANA,NANA,EOT}}, + {EOT}}}, {0x8716, "IT8716F", { {NOLDN, NULL, {0x00,0x04,0x05,0x06,0x07,0x08,0x09,0x0b,0x0c,0x10,
Hello Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31620
to look at the new patch set (#2).
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
util/superiotool/ite.c: add support for IT8613E
Based on not publicly available IT8613E Preliminary Specification V0.3.
Change-Id: Iec99d4d998f645dbad9c803d6d5477580b0bccc4 Signed-off-by: Krystian Hebel krystian.hebel@3mdeb.com --- M util/superiotool/ite.c 1 file changed, 66 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31620/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31620 )
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
Patch Set 6: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/31620/6/util/superiotool/ite.c File util/superiotool/ite.c:
https://review.coreboot.org/#/c/31620/6/util/superiotool/ite.c@331 PS6, Line 331: {0x00,0x00,0x7a,0x00,0x7c,0x01,0x01,EOT}}, {EOT}}}, is missing here
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31620
to look at the new patch set (#7).
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
util/superiotool/ite.c: add support for IT8613E
Based on not publicly available IT8613E Preliminary Specification V0.3.
Change-Id: Iec99d4d998f645dbad9c803d6d5477580b0bccc4 Signed-off-by: Krystian Hebel krystian.hebel@3mdeb.com --- M util/superiotool/ite.c 1 file changed, 67 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31620/7
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31620 )
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31620/7/util/superiotool/ite.c File util/superiotool/ite.c:
https://review.coreboot.org/#/c/31620/7/util/superiotool/ite.c@351 PS7, Line 351: {0x7, "GPIO", if the gpio block has a few registers that show the state of the general purpose inputs, so the register contents only depend on external circuitry, those should probably be marked as NANA
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31620 )
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
Patch Set 8:
did you look into my comment on the last patchset? I'm currently waiting with my +2 for an answer to that; either that it is correct or for a fix if it isn't
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31620
to look at the new patch set (#9).
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
util/superiotool/ite.c: add support for IT8613E
Based on not publicly available IT8613E Preliminary Specification V0.3.
Change-Id: Iec99d4d998f645dbad9c803d6d5477580b0bccc4 Signed-off-by: Krystian Hebel krystian.hebel@3mdeb.com --- M util/superiotool/ite.c 1 file changed, 67 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31620/9
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31620 )
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/#/c/31620/7/util/superiotool/ite.c File util/superiotool/ite.c:
https://review.coreboot.org/#/c/31620/7/util/superiotool/ite.c@351 PS7, Line 351: {0x7, "GPIO",
if the gpio block has a few registers that show the state of the general purpose inputs, so the regi […]
Sorry, I've missed this comment, should be fixed now
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31620 )
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
Patch Set 9: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31620 )
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
Patch Set 9: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31620 )
Change subject: util/superiotool/ite.c: add support for IT8613E ......................................................................
util/superiotool/ite.c: add support for IT8613E
Based on not publicly available IT8613E Preliminary Specification V0.3.
Change-Id: Iec99d4d998f645dbad9c803d6d5477580b0bccc4 Signed-off-by: Krystian Hebel krystian.hebel@3mdeb.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31620 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M util/superiotool/ite.c 1 file changed, 67 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c index 06efc57..8f1e2ea 100644 --- a/util/superiotool/ite.c +++ b/util/superiotool/ite.c @@ -4,6 +4,7 @@ * Copyright (C) 2007 Carl-Daniel Hailfinger * Copyright (C) 2007-2008 Uwe Hermann uwe@hermann-uwe.de * Copyright (C) 2018 Libretrend LDA + * Copyright (C) 2019 Protectli * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -329,6 +330,41 @@ {0x30,0x60,0x61,0x62,0x63,0x70,0x71,EOT}, {0x00,0x00,0x7a,0x00,0x7c,0x01,0x01,EOT}}, {EOT}}}, + {0x8613, "IT8613E", { + {NOLDN, NULL, + {0x20,0x21,0x22,0x23,0x24,0x2b,EOT}, + {0x86,0x13,0x05,0x40,0x00,0x48,EOT}}, + {0x1, "COM1", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x03,0xf8,0x04,0x00,EOT}}, + {0x4, "Environment controller", + {0x30,0x60,0x61,0x62,0x63,0x70,0xf0,0xf1,0xf2,0xf3, + 0xf4,0xf5,0xf6,0xfa,0xfb,0xfc,EOT}, + {0x00,0x02,0x90,0x02,0x30,0x09,0x00,0x00,0x00,0x00, + 0x00,NANA,NANA,0x00,0x00,0x00,EOT}}, + {0x5, "Keyboard", + {0x30,0x60,0x61,0x62,0x63,0x70,0x71,0xf0,EOT}, + {0x01,0x00,0x60,0x00,0x64,0x01,0x02,0x48,EOT}}, + {0x6, "Mouse", + {0x30,0x70,0x71,0xf0,EOT}, + {0x00,0x0c,0x02,0x00,EOT}}, + {0x7, "GPIO", + {0x25,0x26,0x27,0x28,0x29,0x2a,0x2c,0x2d,0x60,0x61, + 0x62,0x63,0x70,0x71,0x72,0x73,0x74,0xb0,0xb1,0xb2, + 0xb3,0xb4,0xb8,0xba,0xbb,0xbc,0xbd,0xc0,0xc1,0xc2, + 0xc3,0xc4,0xc8,0xc9,0xca,0xcb,0xcc,0xcd,0xda,0xdb, + 0xe0,0xe1,0xe2,0xe3,0xe4,0xec,0xf0,0xf1,0xf2,0xf3, + 0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb,EOT}, + {0x00,0xF3,0x00,0x00,0x00,0x01,0x01,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x20,0x38,0x00,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01,0x00,0x00, + 0x40,0x00,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,NANA,NANA, + 0x00,0x00,0x0e,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0xa, "Consumer IR", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x03,0x10,0x0b,0x06,EOT}}, + {EOT}}}, {0x8623, "IT8623E", { /* Defaults are not specified as no datasheet available */ {NOLDN, NULL, @@ -1032,6 +1068,37 @@ };
static const struct superio_registers ec_table[] = { + {0x8613, "IT8613E", { + {NOLDN, NULL, + {0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09, + 0x0a,0x0b,0x0c,0x0e,0x0f,0x11,0x12,0x13,0x14,0x16, + 0x17,0x19,0x1a,0x1c,0x1d,0x1e,0x1f,0x20,0x21,0x22, + 0x24,0x25,0x27,0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2e, + 0x2f,0x30,0x31,0x32,0x33,0x34,0x35,0x38,0x39,0x3a, + 0x3b,0x40,0x41,0x42,0x43,0x44,0x45,0x46,0x47,0x50, + 0x51,0x52,0x53,0x54,0x55,0x56,0x57,0x58,0x59,0x5a, + 0x5b,0x5c,0x5d,0x5e,0x5f,0x68,0x69,0x6a,0x6b,0x6c, + 0x6d,0x6e,0x70,0x71,0x72,0x73,0x74,0x75,0x76,0x78, + 0x79,0x7a,0x7b,0x7c,0x7d,0x7e,0x80,0x81,0x82,0x83, + 0x84,0x85,0x86,0x87,0x88,0x89,0x8a,0x8b,0x8c,0x8d, + 0x8e,0x8f,0x90,0x91,0x98,0x99,0x9c,0x9d,0x9e,0x9f, + 0xa0,0xa1,0xa2,0xa3,0xa4,0xa5,0xa6,0xb4,0xb5,0xb6, + 0xb7,0xb8,0xb9,EOT}, + {0x18,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xC0, + 0x44,0x00,0x00,MISC,MISC,NANA,NANA,0x00,0x40,0x00, + 0x00,MISC,MISC,NANA,NANA,0x00,0x00,MISC,MISC,MISC, + MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC, + MISC,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA, + NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,0x00, + 0x00,0x7f,0x7f,0x7f,0x40,0x00,0x00,0x90,0x00,0x00, + 0x12,0x60,0x00,0x00,0x00,0x7f,0x7f,0x7f,0x00,0x00, + 0x7f,0x0f,0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f,0x7f, + 0x7f,0x7f,0x00,0x00,0x7f,0x0f,MISC,MISC,MISC,MISC, + NANA,NANA,NANA,NANA,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,MISC,0x00,0x00,0x00,0x00,0x00,NANA,0x00,NANA, + 0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f,NANA,NANA,NANA, + NANA,NANA,NANA,EOT}}, + {EOT}}}, {0x8716, "IT8716F", { {NOLDN, NULL, {0x00,0x04,0x05,0x06,0x07,0x08,0x09,0x0b,0x0c,0x10,
-
Felix Held (Code Review) -
Krystian Hebel (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)