Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34981 )
Change subject: google/rambi: Replace __PRE_RAM__ with ENV_ROMSTAGE ......................................................................
google/rambi: Replace __PRE_RAM__ with ENV_ROMSTAGE
Change-Id: I9d86f8475221b52ccdb45cdeaf538e85ab7a17c0 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/google/rambi/chromeos.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/34981/1
diff --git a/src/mainboard/google/rambi/chromeos.c b/src/mainboard/google/rambi/chromeos.c index 859fb0b..3472b1c 100644 --- a/src/mainboard/google/rambi/chromeos.c +++ b/src/mainboard/google/rambi/chromeos.c @@ -41,9 +41,8 @@ * there is a 10K pullup. Disable the internal pull in romstage so that * there isn't any ambiguity in the reading. */ -#if defined(__PRE_RAM__) - ssus_disable_internal_pull(WP_STATUS_PAD); -#endif + if (ENV_ROMSTAGE) + ssus_disable_internal_pull(WP_STATUS_PAD);
/* WP is enabled when the pin is reading high. */ return ssus_get_gpio(WP_STATUS_PAD);
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34981 )
Change subject: google/rambi: Replace __PRE_RAM__ with ENV_ROMSTAGE ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34981 )
Change subject: google/rambi: Replace __PRE_RAM__ with ENV_ROMSTAGE ......................................................................
google/rambi: Replace __PRE_RAM__ with ENV_ROMSTAGE
Change-Id: I9d86f8475221b52ccdb45cdeaf538e85ab7a17c0 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34981 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/rambi/chromeos.c 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/rambi/chromeos.c b/src/mainboard/google/rambi/chromeos.c index 859fb0b..3472b1c 100644 --- a/src/mainboard/google/rambi/chromeos.c +++ b/src/mainboard/google/rambi/chromeos.c @@ -41,9 +41,8 @@ * there is a 10K pullup. Disable the internal pull in romstage so that * there isn't any ambiguity in the reading. */ -#if defined(__PRE_RAM__) - ssus_disable_internal_pull(WP_STATUS_PAD); -#endif + if (ENV_ROMSTAGE) + ssus_disable_internal_pull(WP_STATUS_PAD);
/* WP is enabled when the pin is reading high. */ return ssus_get_gpio(WP_STATUS_PAD);
-
Furquan Shaikh (Code Review) -
Kyösti Mälkki (Code Review)