Change in coreboot[master]: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46365 )
Change subject: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override ......................................................................
mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override
Configuring this option here in the mainboard affects all boards. For example, for the Asus F2A85-M PRO, the default should be `y`, if the blobs repository is selected, but it is not selected.
│ Symbol: HUDSON_XHCI_ENABLE [=n] │ │ Type : boolean │ │ Prompt: Enable Hudson XHCI Controller │ │ Location: │ │ -> Chipset │ │ Prompt: Enable Hudson XHCI Controller │ │ Location: │ │ -> Chipset │ │ Defined at src/mainboard/asus/a88xm-e/Kconfig:51 │ │ Depends on: VENDOR_ASUS [=y] && BOARD_ASUS_A88XM_E [=n] │
As this option is configurable under *Chipset*, use the same default for all boards and let the user choose. Board specific defaults only cause confusion.
Change-Id: Iaeb27c42e97991f9389753856bd7deb3944e22d9 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/asus/a88xm-e/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/46365/1
diff --git a/src/mainboard/asus/a88xm-e/Kconfig b/src/mainboard/asus/a88xm-e/Kconfig index 17fbe28..622f1bd 100644 --- a/src/mainboard/asus/a88xm-e/Kconfig +++ b/src/mainboard/asus/a88xm-e/Kconfig @@ -48,10 +48,6 @@ string default "1002,990e"
-config HUDSON_XHCI_ENABLE - bool - default n - config HUDSON_LEGACY_FREE bool default n
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46365 )
Change subject: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override ......................................................................
Patch Set 1:
Is this really affecting other boards? I agree to the change, but the reasoning seems odd.
The F2A85-M overrides `HUDSON_XHCI_FWM` to `n` btw. So I don't see how this change could make a difference there.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46365 )
Change subject: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override ......................................................................
Patch Set 1:
I guess, then I am confused by
Defined at src/mainboard/asus/a88xm-e/Kconfig:51
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46365 )
Change subject: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override ......................................................................
Patch Set 1:
I guess, then I am confused by
Defined at src/mainboard/asus/a88xm-e/Kconfig:51
It shows wherever it shows up first, asus/a is just early in the alphabetical order. This could be avoided by "declaring" the config in advance, before the mainboard Kconfig files are included.
Hello Mike Banon, build bot (Jenkins), Nico Huber, Angel Pons, Balázs Vinarz,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46365
to look at the new patch set (#2).
Change subject: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override ......................................................................
mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override
This option is configurable under *Chipset*, so use the same default for all boards and let the user choose. Board specific defaults only cause confusion.
Change-Id: Iaeb27c42e97991f9389753856bd7deb3944e22d9 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/asus/a88xm-e/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/46365/2
Balázs Vinarz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46365 )
Change subject: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override ......................................................................
Patch Set 2: Code-Review-1
AFAIR, the USB3 ports were really problematic. Most of the time it was really slow, somewhere around USB 1.x speed. The only way to have the ports properly working to reset the motherboard with the coreboot bios chip in, while the factory bios was loaded. And this way somehow the old fw remain in the controller and the ports were fast as they should be.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46365 )
Change subject: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override ......................................................................
Patch Set 2:
Thank you for the insight. Isn’t it better to have the ports at least somewhat working with limited speed over not having them working at all?
I created [issue #285][1] for the USB speed issue.
[1]: https://ticket.coreboot.org/issues/285
Balázs Vinarz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46365 )
Change subject: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override ......................................................................
Patch Set 2:
Patch Set 2:
Thank you for the insight. Isn’t it better to have the ports at least somewhat working with limited speed over not having them working at all?
I created [issue #285][1] for the USB speed issue.
If we left this option unset, the XHCI ports will work as USB2.0, with much better troughput than USB1.x :)
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46365?usp=email )
Change subject: mb/asus/a88xm-e/Kconfig: Remove `HUDSON_XHCI_ENABLE` override ......................................................................
Abandoned
-
Balázs Vinarz (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)