Attention is currently required from: Bora Guvendik, Hannah Williams, Tarun Tuli, Jamie Ryu, Subrata Banik, Wonkyu Kim, Paul Menzel, Kapil Porwal.
Jay Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73191 )
Change subject: soc/intel/mtl/romstage: Insert EC boot timestamps
......................................................................
Patch Set 10:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73191/comment/1416797c_a9b28798
PS4, Line 9: Calls the function to insert EC boot timestamps to the coreboot
can you add a sample snippet of cbmem -t output with these timestamps? (somewhere in the patch trai […]
Added in the shared design doc mentioned in the bug.
File src/soc/intel/meteorlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/73191/comment/3f226738_6e2d0379
PS3, Line 142: insert_ec_event_timestamps();
the function computes -ve timestamps based on SOC timer. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebda928a31d55a081f68b9833b66f757a9cd9aa7
Gerrit-Change-Number: 73191
Gerrit-PatchSet: 10
Gerrit-Owner: Jay Patel
jay2.patel@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 16:45:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jay Patel
jay2.patel@intel.com
Gerrit-MessageType: comment