Change in coreboot[master]: drivers/intel/mipi_camera: Support adding camera power resource
Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41624 )
Change subject: drivers/intel/mipi_camera: Support adding camera power resource ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41624/16/src/drivers/intel/mipi_cam... File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/41624/16/src/drivers/intel/mipi_cam... PS16, Line 185: const char *pr3; IMO coreboot should be like other firmwares and not have a PR3 (or at least have a non-empty PR3) since it 1) tells the OS to leave the camera on in D3 and 2) inconsistently doesn't have a PR1 or PR2 for D1 and D2. A prior example and debate (which I don't plan to re-hash here, so mostly food for thought):
https://review.coreboot.org/c/coreboot/+/28073
-
Matt Delco (Code Review)