Attention is currently required from: Arthur Heymans, Eric Lai, Kapil Porwal, Paul Menzel, Subrata Banik.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78386?usp=email )
Change subject: drivers/intel/dptf: Add DCFG support
......................................................................
Patch Set 5:
(3 comments)
File src/drivers/intel/dptf/chip.h:
https://review.coreboot.org/c/coreboot/+/78386/comment/f5ad68ec_554964bb :
PS5, Line 77: uint32_t
what is the possible range for dcfg variable ?
DCFG is 32 bit register.
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/78386/comment/209a0655_317caf96 :
PS5, Line 162: DPTF
copy pasta?
Acknowledged
https://review.coreboot.org/c/coreboot/+/78386/comment/d67d3a52_b0f16c1a :
PS5, Line 164:
: acpigen_write_method("DCFG", 0);
: acpigen_emit_byte(RETURN_OP);
: acpigen_write_integer(config->dcfg);
: acpigen_write_method_end();
why not use acpigen_write_name_integer("DCFG", config->dcfg) ? It does not have to be a method afaic […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78386?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I507c4d6eee565d39b2f42950d888d110ab94de64
Gerrit-Change-Number: 78386
Gerrit-PatchSet: 5
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 20 Mar 2024 06:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment