Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad Th...
Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. ......................................................................
mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/1
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 24b869c..966c06e 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -161,5 +161,45 @@ end end end # PMC + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| chipset_lockdown | CHIPSET_LOCKDOWN_COREBOOT | + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| GSPI1 | Fingerprint MCU | + #| I2C0 | Audio | + #| I2C1 | Touchscreen | + #| I2C2 | WLAN, SAR0 | + #| I2C3 | Camera, SAR1 | + #| I2C5 | Trackpad | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + }, + .i2c[1] = { + }, + .i2c[2] = { + }, + .i2c[3] = { + }, + .i2c[5] = { + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 163, + .scl_hcnt = 75, + .sda_hold = 36, + }, + }, + }" end end
Johnny Li has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42964/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42964/2//COMMIT_MSG@7 PS2, Line 7: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad Please remove the space before the colon.
https://review.coreboot.org/c/coreboot/+/42964/2//COMMIT_MSG@9 PS2, Line 9: This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. 1. Please wrap the line after 75 characters. 2. Please mention the current frequency.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#3).
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.
Signed-off-by:Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#4).
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST= Verified that I2C5 frequency is 388kHz.
Signed-off-by:Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/4
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#5).
Change subject: mb/google/volteer/variants/volteer:Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer:Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST= Verified that I2C5 frequency is 388kHz.
Signed-off-by:Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id:If26bfdd319a80ed2484e5a2cda642c11385de671 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/5
Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer:Tune I2C5 params for Trackpad ......................................................................
Patch Set 5:
(1 comment)
hi paul please help to review command message again
https://review.coreboot.org/c/coreboot/+/42964/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42964/2//COMMIT_MSG@7 PS2, Line 7: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
Please remove the space before the colon.
Ack
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#6).
Change subject: mb/google/volteer/variants/volteer:Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer:Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST= Verified that I2C5 frequency is 388kHz.
Signed-off-by:Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id:If26bfdd319a80ed2484e5a2cda642c11385de671 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/6
Mark Hsieh has uploaded a new patch set (#7) to the change originally created by Johnny Li. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad. ......................................................................
mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad.
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id:If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by:Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/7
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad. ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG@7 PS6, Line 7: mb/google/volteer/variants/volteer:Tune Please add the space *after* the colon back.
mb/google/volteer/variants/volteer: Tune I2C5 params for Trackpad
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG@8 PS6, Line 8: Describe the problem:
The bus frequency is currently … kHz, which is too low/high.
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG@10 PS6, Line 10: to bring the bus frequency closer to 400kHz. Space after comma:
This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad. ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42964/7//COMMIT_MSG@8 PS7, Line 8: 400 kHZ for trackpad. Please use just one line, and remove the dot/period at the end of the commit message summary.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad. ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG@7 PS6, Line 7: mb/google/volteer/variants/volteer:Tune
Please add the space *after* the colon back. […]
Fixed in Mark’s patch set.
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG@8 PS6, Line 8:
Describe the problem: […]
Fixed in Mark’s patch set.
https://review.coreboot.org/c/coreboot/+/42964/6//COMMIT_MSG@10 PS6, Line 10: to bring the bus frequency closer to 400kHz.
Space after comma: […]
Fixed in Mark’s patch set.
https://review.coreboot.org/c/coreboot/+/42964/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42964/7//COMMIT_MSG@18 PS7, Line 18: Signed-off-by:Johnny Li johnny_li@wistron.corp-partner.google.com Please add a space after the colon. (This build bot complains about a missing Signed-off-by line.)
Mark Hsieh has uploaded a new patch set (#8) to the change originally created by Johnny Li. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad. ......................................................................
mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad.
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id:If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/8
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/variants/volteer: Increase I2C5 bus freq closer to 400 kHZ for trackpad. ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42964/7//COMMIT_MSG@7 PS7, Line 7: variants In some commits, this is abbreviated to *var*.
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
Mark Hsieh has uploaded a new patch set (#9) to the change originally created by Johnny Li. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id:If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/9
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#10).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id:If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/10
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 10: Code-Review+1
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 10:
(3 comments)
please organize the i2c patches into a stack of patches. right now, they all merge-conflict with each other. also, add a "first" patch to introduce the minimal "Intel Common SoC Config" section so that the i2c tuning patches are incremental refinements to the basic structure.
https://review.coreboot.org/c/coreboot/+/42964/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/10/src/mainboard/google/volte... PS10, Line 164: # one tab.
https://review.coreboot.org/c/coreboot/+/42964/10/src/mainboard/google/volte... PS10, Line 181: .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, : .gspi[0] = { : .speed_mhz = 1, : .early_init = 1, : }, this section doesn't really relate to i2c tuning and should be split into a separate patch.
https://review.coreboot.org/c/coreboot/+/42964/10/src/mainboard/google/volte... PS10, Line 186: .i2c[0] = { : }, : .i2c[1] = { : }, : .i2c[2] = { : }, : .i2c[3] = { : }, you don't need these here because you have separate patches to add them with proper timing info.
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#11).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/11
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#12).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/12
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#13).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400 kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is 394 kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/13
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#14).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 28 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/14
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#15).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400 kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is 388 kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 28 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/15
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/15/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/15/src/mainboard/google/volte... PS15, Line 164: # Intel Common SoC Config : #+-------------------+---------------------------+ : #| Field | Value | : #+-------------------+---------------------------+ : #| chipset_lockdown | CHIPSET_LOCKDOWN_COREBOOT | : #| GSPI0 | cr50 TPM. Early init is | : #| | required to set up a BAR | : #| | for TPM communication | : #| | before memory is up | : #| GSPI1 | Fingerprint MCU | : #| I2C0 | Audio | : #| I2C1 | Touchscreen | : #| I2C2 | WLAN, SAR0 | : #| I2C3 | Camera, SAR1 | : #| I2C5 | Trackpad | : #+-------------------+---------------------------+ : register "common_soc_config" = "{ : .i2c[5] = { : .speed = I2C_SPEED_FAST, : .speed_config[0] = { : .speed = I2C_SPEED_FAST, : .scl_lcnt = 163, : .scl_hcnt = 75, : .sda_hold = 36, : }, : }, : }" : Please put this between what's currently on lines 1 and 2 of this file. Thanks.
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#16).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400 kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is 388 kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 28 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/16
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#17).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 28 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/17
Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 16:
(1 comment)
Hi Nick please command
https://review.coreboot.org/c/coreboot/+/42964/15/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/15/src/mainboard/google/volte... PS15, Line 164: # Intel Common SoC Config : #+-------------------+---------------------------+ : #| Field | Value | : #+-------------------+---------------------------+ : #| chipset_lockdown | CHIPSET_LOCKDOWN_COREBOOT | : #| GSPI0 | cr50 TPM. Early init is | : #| | required to set up a BAR | : #| | for TPM communication | : #| | before memory is up | : #| GSPI1 | Fingerprint MCU | : #| I2C0 | Audio | : #| I2C1 | Touchscreen | : #| I2C2 | WLAN, SAR0 | : #| I2C3 | Camera, SAR1 | : #| I2C5 | Trackpad | : #+-------------------+---------------------------+ : register "common_soc_config" = "{ : .i2c[5] = { : .speed = I2C_SPEED_FAST, : .speed_config[0] = { : .speed = I2C_SPEED_FAST, : .scl_lcnt = 163, : .scl_hcnt = 75, : .sda_hold = 36, : }, : }, : }" :
Please put this between what's currently on lines 1 and 2 of this file. Thanks.
Ack
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#18).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 29 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/18
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/18/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/18/src/mainboard/google/volte... PS18, Line 29: device domain 0 on trailing whitespace
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#19).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 29 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/19
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 19: Code-Review+2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/19/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/19/src/mainboard/google/volte... PS19, Line 2: # Intel Common SoC Config please replace spaces with tabs for indentation.
Nick Vaccaro has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Removed Code-Review+2 by Nick Vaccaro nvaccaro@google.com
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#20).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 29 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/20
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/20/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/20/src/mainboard/google/volte... PS20, Line 20: Tabs are needed here as well as on lines 21, and 23 through 28 below.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/20/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/20/src/mainboard/google/volte... PS20, Line 20:
Tabs are needed here as well as on lines 21, and 23 through 28 below.
Looks like line 22 is also mixed spaces/tabs. Please convert to tabs.
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#21).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/21
Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 21:
hi nick i have already to check each line no space and tap mix
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/21/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/21/src/mainboard/google/volte... PS21, Line 20: .speed = I2C_SPEED_FAST, : .speed_config[0] = { : .speed = I2C_SPEED_FAST, : .scl_lcnt = 163, : .scl_hcnt = 75, : .sda_hold = 36, this section still needs more indentation.
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#22).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/22
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#23).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/23
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#24).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 27 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/24
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#25).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/25
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#26).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/26
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42964/26/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42964/26/src/mainboard/google/volte... PS26, Line 2: register "SaGv" = "SaGv_Disabled" do you need to rebase?
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#27).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/27
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42964
to look at the new patch set (#28).
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
The current I2C5 bus frequency is 367 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C5 frequency is between 389-396kHz.
Change-Id: If26bfdd319a80ed2484e5a2cda642c11385de671 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 60 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/42964/28
Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42964 )
Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Caveh Jalali (Code Review)
-
Johnny Li (Code Review)
-
Mark Hsieh (Code Review)
-
Nick Vaccaro (Code Review)
-
Paul Menzel (Code Review)